From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A707CC4727C for ; Fri, 25 Sep 2020 15:13:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CEFC208B6 for ; Fri, 25 Sep 2020 15:13:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZU3Z9Ugk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729274AbgIYPNc (ORCPT ); Fri, 25 Sep 2020 11:13:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728858AbgIYPNc (ORCPT ); Fri, 25 Sep 2020 11:13:32 -0400 Received: from mail-oo1-xc44.google.com (mail-oo1-xc44.google.com [IPv6:2607:f8b0:4864:20::c44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D8EEC0613D4 for ; Fri, 25 Sep 2020 08:13:32 -0700 (PDT) Received: by mail-oo1-xc44.google.com with SMTP id w25so823229oos.10 for ; Fri, 25 Sep 2020 08:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=o2Exc0VBzd1ZNlpHVolK8GIrxWSC5fjv/MamEye1CJU=; b=ZU3Z9UgkdkEleoOCD2pAZl7P746k2eSXo1QpjnhEr/LIKvmhtAYVxNwwxdjdGe/8jp yizjFfOFng297w6kW82u/7EK9fl5bdl1XRjTw/ujyJl5Rdew/OOBkOX7Vjv+/vEEG559 qe1lQ8yo5qj0smPTw/NSREaaPyYKYrEujCR6r4z28CLPUOpZlixAJpCBF6u8oJ1xGlsL CaSQicVjlrPJ+uqN98DTIzQDj6qYSV3c2Jh+a6LZgZCBo9q5wwQvZ83o1NrowIOQWwzS rzgu47afS7y8NTjp9OX3duZkS2qItbsNxNcrtdHB5UGKEwxdpjw8dd+0HI45FPpCnFUQ ViSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=o2Exc0VBzd1ZNlpHVolK8GIrxWSC5fjv/MamEye1CJU=; b=ZG5uitZq+PYrAzAHDz1rwcxvLsuQyV1kMGvG2lA2eEKi19VlVUM8x4vroR2sw2aFAv t+NtPXtz96OIOB6XeR2arLFY0sVqyzIFZsTabndqCepwkhC/OIT0eUVhE11f9oKFf4HK 0isCRr9l/fHxxW/Lf6qg2bJFuYxQmmaU/eeesE+E4jX3d3h5CL5WRTLmmbEOnyxQjngh fFZ+jq4urVzamcobYx2YWwMu4N2mbV97kxxCsKr1xkfknCDEBK+IsC4dQ0Nk3dIrMQ4A Khy/e/ZYgvvnXplpTuxkt7J86EBOXwXl6ic/gIllNRZcQgH4ljRxyE6LxIveV0Y6fQGo Qi8Q== X-Gm-Message-State: AOAM531OMGcl07xesp2MpjzDa47tZckFoRmaW+xR+uQ7wXE3+P9amKCt 4AjY/AI9tSliIvRRmKdiOG4+kQ== X-Google-Smtp-Source: ABdhPJxEWKdnpqf5Z7ph3yamNi6DbElNakvjUXJwVJzGCJsO9xYsMWxm0+GWTqRp12Q29DfPg8KFwA== X-Received: by 2002:a4a:e516:: with SMTP id r22mr1182921oot.3.1601046811391; Fri, 25 Sep 2020 08:13:31 -0700 (PDT) Received: from yoga (99-135-181-32.lightspeed.austtx.sbcglobal.net. [99.135.181.32]) by smtp.gmail.com with ESMTPSA id x15sm746755oor.33.2020.09.25.08.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 08:13:30 -0700 (PDT) Date: Fri, 25 Sep 2020 10:13:28 -0500 From: Bjorn Andersson To: Qinglang Miao Cc: Stanimir Varbanov , Andy Gross , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] media: venus: simplify the return expression of session_process_buf() Message-ID: <20200925151328.GC2510@yoga> References: <20200921131038.92204-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921131038.92204-1-miaoqinglang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 21 Sep 08:10 CDT 2020, Qinglang Miao wrote: > Simplify the return expression. > Reviewed-by: Bjorn Andersson > Signed-off-by: Qinglang Miao > --- > drivers/media/platform/qcom/venus/helpers.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c > index 50439eb1f..fb3fd3640 100644 > --- a/drivers/media/platform/qcom/venus/helpers.c > +++ b/drivers/media/platform/qcom/venus/helpers.c > @@ -439,7 +439,6 @@ session_process_buf(struct venus_inst *inst, struct vb2_v4l2_buffer *vbuf) > struct vb2_buffer *vb = &vbuf->vb2_buf; > unsigned int type = vb->type; > struct hfi_frame_data fdata; > - int ret; > > memset(&fdata, 0, sizeof(fdata)); > fdata.alloc_len = buf->size; > @@ -470,11 +469,7 @@ session_process_buf(struct venus_inst *inst, struct vb2_v4l2_buffer *vbuf) > fdata.offset = 0; > } > > - ret = hfi_session_process_buf(inst, &fdata); > - if (ret) > - return ret; > - > - return 0; > + return hfi_session_process_buf(inst, &fdata); > } > > static bool is_dynamic_bufmode(struct venus_inst *inst) > -- > 2.23.0 >