From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: robh+dt@kernel.org, patches@opensource.cirrus.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Lucas Tanure <tanureal@opensource.cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>
Subject: Re: [PATCH 2/3] ASoC: cs4234: Add support for Cirrus Logic CS4234 codec
Date: Fri, 25 Sep 2020 17:41:29 +0100 [thread overview]
Message-ID: <20200925164129.GG4841@sirena.org.uk> (raw)
In-Reply-To: <20200925105908.20640-2-rf@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
On Fri, Sep 25, 2020 at 11:59:07AM +0100, Richard Fitzgerald wrote:
This looks very good, a couple of small nits below which should be easy
to address:
> @@ -282,7 +283,6 @@ config SND_SOC_ALL_CODECS
> uses them is also built since they are only usable with a machine
> driver. Selecting this option will allow these drivers to be built
> without an explicit machine driver for test and development purposes.
> -
> Support for the bus types used to access the codecs to be built must
> be selected separately.
>
Unrelated whitespace change.
> +static int cs4234_i2c_remove(struct i2c_client *i2c_client)
> +{
> + struct cs4234 *cs4234 = i2c_get_clientdata(i2c_client);
> +
> + pm_runtime_disable(&i2c_client->dev);
> + cs4234_shutdown(cs4234);
You used devm_snd_soc_register_component() which means that you won't
unregister utill after this force powered down the device which isn't
great - you should use snd_soc_register_component() and manually
unregister here before force powering the device down.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-25 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 10:59 [PATCH 1/3] ASoC: cs4234: Add dtschema binding document Richard Fitzgerald
2020-09-25 10:59 ` [PATCH 2/3] ASoC: cs4234: Add support for Cirrus Logic CS4234 codec Richard Fitzgerald
2020-09-25 16:41 ` Mark Brown [this message]
2020-09-25 10:59 ` [PATCH 3/3] MAINTAINERS: Update Cirrus Logic Codecs maintainers Richard Fitzgerald
2020-09-25 20:41 ` [PATCH 1/3] ASoC: cs4234: Add dtschema binding document Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925164129.GG4841@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=tanureal@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox