Re: [PATCH 11/11] drivers/edac: convert pci counters to counter_atomic32

Borislav Petkov
2020-09-28T12:05:14Z

On Fri, Sep 25, 2020 at 05:47:25PM -0600, Shuah Khan wrote:
> counter_atomic* is introduced to be used when a variable is used as
> a simple counter and doesn't guard object lifetimes. This clearly
> differentiates atomic_t usages that guard object lifetimes.
>
> counter_atomic* variables will wrap around to 0 when it overflows and
> should not be used to guard resource lifetimes, device usage and
> open counts that control state changes, and pm states.
>
> atomic_t variables used for pci counters keep track of pci parity and
> non-parity errors. Convert them to use counter_atomic32.
>
> Overflow will wrap around and reset the counts as was the case prior to
> the conversion.
>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
> drivers/edac/edac_pci.h | 5 +++--
> drivers/edac/edac_pci_sysfs.c | 28 ++++++++++++++--------------
> 2 files changed, 17 insertions(+), 16 deletions(-)

The patches I was Cced - this one and the apei one, look ok to me.

Acked-by: Borislav Petkov <bp@suse.de>

Thx.

--
Regards/Gruss,
Boris.