From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F60C4363D for ; Fri, 25 Sep 2020 17:04:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 140AD208B6 for ; Fri, 25 Sep 2020 17:04:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601053496; bh=aUMa/PDzTOQKkRA+DzvGc28ks3CAnm0M/jJhIkzKfTQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=pql5l9ScYbPk0zWUgGqA+CnxhrhWqAs//RD4vMR+wMbsNhQX68vCusVrGdkXVCYk1 WvhyQVOm64bAwUvkmvh67z6dTeCf3RO9dk3WGfe0WCd1PWXjyhgkHeLssb4HwTR/82 T5uiJjzfLGdTUewDLZyESBByah2wKWQcypxDIcm4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729629AbgIYREz (ORCPT ); Fri, 25 Sep 2020 13:04:55 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:44359 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729477AbgIYREy (ORCPT ); Fri, 25 Sep 2020 13:04:54 -0400 Received: by mail-ed1-f67.google.com with SMTP id b12so3177995edz.11; Fri, 25 Sep 2020 10:04:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7H2Bk9gpg/w+wUoObaKvu/mtCEHvMrdXma3hhs6oCPA=; b=g5ROF5GAZPfAatV61rQHJl341YAEAuOoWj3mA6fNWcvgEmeRA6AnzPWUCO0meGlFZB 5KWvHRCasYK+eri7tronQb7RMA6EjerGe3dPGvDQrP8XOGpCDpwx5c5vNo5L0b+b2WLn /tgT0HzC1h0k4+gX9EsyTsi9GKFSc/jYD5GJq327/1puQLvc4GcngZCOafQdbe5wJmXA Xbx0kSWFux7hZOAJpIeQYYlGLr808OU9Q5Jujdmfz/JOqvYjqjR6mRI2XRPK3EZIGkFN tQjBYnO5s6o1bhDMOO2bpRKSBtAU7EfqP0ziDkDbFkVAqP7HsSvLciIAM8JU13BDTS1B dDyQ== X-Gm-Message-State: AOAM531KgPhYkHpSXfqzYrPTdY5ofujCN9WgzTIFINEzwsPM0UffJp+A lOh5HK1TZrxoAAqzYWBTDLg= X-Google-Smtp-Source: ABdhPJzshXZU4mumXpaaqCcRqza8EX1pZ67x1HLojNLckvWgfrfQH6BmnBoLuzW1ylscuLUKq7fF/A== X-Received: by 2002:a50:c8cd:: with SMTP id k13mr2333610edh.387.1601053492597; Fri, 25 Sep 2020 10:04:52 -0700 (PDT) Received: from kozik-lap ([194.230.155.132]) by smtp.googlemail.com with ESMTPSA id 40sm2174254edr.67.2020.09.25.10.04.50 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Sep 2020 10:04:51 -0700 (PDT) Date: Fri, 25 Sep 2020 19:04:49 +0200 From: Krzysztof Kozlowski To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Kevin Hilman , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Ulf Hansson , linux-mmc@vger.kernel.org Subject: Re: [PATCH] mmc: host: fix depends for MMC_MESON_GX w/ COMPILE_TEST Message-ID: <20200925170449.GA18717@kozik-lap> References: <20200925164323.29843-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200925164323.29843-1-rdunlap@infradead.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 09:43:23AM -0700, Randy Dunlap wrote: > Fix build errors for meson-gx-mmc.c when CONFIG_COMMON_CLK is not > set/enabled. This can happen when COMPILE_TEST is set/enabled. > > ERROR: modpost: "clk_divider_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined! > ERROR: modpost: "devm_clk_register" [drivers/mmc/host/meson-gx-mmc.ko] undefined! > ERROR: modpost: "clk_mux_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined! > ERROR: modpost: "__clk_get_name" [drivers/mmc/host/meson-gx-mmc.ko] undefined! > > Fixes: 54d8454436a2 ("mmc: host: Enable compile testing of multiple drivers") > Signed-off-by: Randy Dunlap > Cc: Kevin Hilman > Cc: linux-amlogic@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: Ulf Hansson > Cc: linux-mmc@vger.kernel.org > Cc: Krzysztof Kozlowski > --- > drivers/mmc/host/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20200925.orig/drivers/mmc/host/Kconfig > +++ linux-next-20200925/drivers/mmc/host/Kconfig > @@ -425,6 +425,7 @@ config MMC_SDHCI_IPROC > config MMC_MESON_GX > tristate "Amlogic S905/GX*/AXG SD/MMC Host Controller support" > depends on ARCH_MESON|| COMPILE_TEST > + depends on COMMON_CLK I received a report from kbuild about this when I posted the patchset but somehow I was not able to reproduce it... or I skipped this for reason I do not remember now, my bad. Anyway, thanks for fixing, looks ok: Reviewed-by: Krzysztof Kozlowski Also please for the credits (as Kbuild did report it to me): Reported-by: kernel test robot Best regards, Krzysztof > help > This selects support for the Amlogic SD/MMC Host Controller > found on the S905/GX*/AXG family of SoCs. This controller is