From: Borislav Petkov <bp@alien8.de>
To: Arvind Sankar <nivedita@alum.mit.edu>
Cc: Feng Tang <feng.tang@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Yazen Ghannam <yazen.ghannam@amd.com>,
Wei Huang <wei.huang2@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Dave Hansen <dave.hansen@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2] tools/x86: add kcpuid tool to show raw CPU features
Date: Fri, 25 Sep 2020 22:57:51 +0200 [thread overview]
Message-ID: <20200925205751.GR16872@zn.tnic> (raw)
In-Reply-To: <20200925204047.GA769219@rani.riverdale.lan>
On Fri, Sep 25, 2020 at 04:40:47PM -0400, Arvind Sankar wrote:
> They're not the same, but aren't there going to be quite a few common
> flags between the definitions in cpufeatures.h and the definitions in
> cpuid.txt? If they're both living in the kernel repo, it would be nice
> for them to not duplicate what's common between them, no?
You will generate cpuid.txt exactly once and shortly after cpufeatures.h
will already be ancient in comparison to it. So there would be no point
to share.
Also, have a look at which leafs are in cpufeatures.h, which of those
leafs are synthetic and how many leafs are in an actual CPUID hw
implementation.
Then, some of the bits in cpufeatures.h are not present while the leafs
in CPUID have them for the above reason.
And so on...
> This shouldn't affect how easy it is to update, I think. The kernel
> build will use whatever version is in the source tree, the tool will use
> whatever version is installed under /usr/share, so the latter can be
> updated without needing a new kernel.
And I believe that keeping those apart because there are differences,
would cause more confusion vs having the two things completely separate.
So I actually think that sharing between the two is not even worth the
effort.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-09-25 20:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 5:27 [RFC PATCH v2] tools/x86: add kcpuid tool to show raw CPU features Feng Tang
2020-09-22 19:38 ` Dave Hansen
2020-09-25 7:22 ` Feng Tang
2020-09-25 17:27 ` Borislav Petkov
2020-09-22 20:10 ` Borislav Petkov
2020-09-22 22:15 ` Arvind Sankar
2020-09-23 2:45 ` Feng Tang
2020-09-25 17:16 ` Borislav Petkov
2020-09-25 19:48 ` Arvind Sankar
2020-09-25 20:17 ` Borislav Petkov
2020-09-25 20:40 ` Arvind Sankar
2020-09-25 20:57 ` Borislav Petkov [this message]
2020-09-25 17:24 ` Borislav Petkov
2020-09-25 17:26 ` Dave Hansen
2020-09-28 7:07 ` Feng Tang
2020-09-28 8:34 ` Borislav Petkov
2020-09-28 8:56 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925205751.GR16872@zn.tnic \
--to=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=feng.tang@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nivedita@alum.mit.edu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=wei.huang2@amd.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox