From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C220C4741F for ; Sat, 26 Sep 2020 06:09:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C20FB20866 for ; Sat, 26 Sep 2020 06:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601100558; bh=ZeejMl78FpNmaWLn4IWOjxzAceUcnpcPTZfOBMWUOmM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=A09/3wilD0bsPGLMHPiBX50ykJ2+tQIXmbARGzMie5BZfPuU+Bv1TVC7sacRUvnHS Ve+tCdzrRIwjw4AK6K5qGT+Urv1qYECCiCIWS9P1CLW8RCshO7e3RwGi/aQ+pQWtxx 3PnGSshgagyLdCxZ4v7xlsH8LFwb/Op/n1LYidCE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728069AbgIZGJS (ORCPT ); Sat, 26 Sep 2020 02:09:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:58702 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726119AbgIZGJR (ORCPT ); Sat, 26 Sep 2020 02:09:17 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B7B42080C; Sat, 26 Sep 2020 06:09:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601100557; bh=ZeejMl78FpNmaWLn4IWOjxzAceUcnpcPTZfOBMWUOmM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YaKt93uAqeL7Vzi2qCOH7qSqkfuYEsw5Il7THjGFHWoF0gzpKkMIil519Qsmnp3M1 wLUsMn4miE4fXm8IIhsL+BXIWaU7JsEG0wpDFqbO+E69UA/v9IFRcif/n8MUhKNYXm 5UR9/JrX28UdMkQlpGTQDKorTC7RwqY2NReo5FQU= Date: Sat, 26 Sep 2020 08:09:13 +0200 From: Greg KH To: Xu Yilun Cc: Moritz Fischer , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, trix@redhat.com, lgoncalv@redhat.com, hao.wu@intel.com Subject: Re: [PATCH v3 1/5] fpga: dfl: rename the bus type "dfl" to "fpga-dfl" Message-ID: <20200926060913.GA637197@kroah.com> References: <1600966801-30586-1-git-send-email-yilun.xu@intel.com> <1600966801-30586-2-git-send-email-yilun.xu@intel.com> <20200924172700.GA79736@archbook> <20200926022346.GA5623@yilunxu-OptiPlex-7050> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200926022346.GA5623@yilunxu-OptiPlex-7050> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 26, 2020 at 10:23:46AM +0800, Xu Yilun wrote: > Hi greg, > > About the bus naming, I summarized some questions we've discussed to check > with you. See inline. > > On Thu, Sep 24, 2020 at 10:27:00AM -0700, Moritz Fischer wrote: > > Hi Xu, > > > > On Fri, Sep 25, 2020 at 12:59:57AM +0800, Xu Yilun wrote: > > > Now the DFL device drivers could be made as independent modules and put > > > in different subsystems according to their functionalities. So the name > > > should be descriptive and unique in the whole kernel. > > > > > > The patch changes the naming of dfl bus related structures, functions, > > > APIs and documentations. > > > > > > Signed-off-by: Xu Yilun > > > --- > > > Documentation/ABI/testing/sysfs-bus-dfl | 15 -- > > > Documentation/ABI/testing/sysfs-bus-fpga-dfl | 15 ++ > > > MAINTAINERS | 2 +- > > > drivers/fpga/dfl.c | 254 ++++++++++++++------------- > > > drivers/fpga/dfl.h | 77 ++++---- > > > 5 files changed, 184 insertions(+), 179 deletions(-) > > > delete mode 100644 Documentation/ABI/testing/sysfs-bus-dfl > > > create mode 100644 Documentation/ABI/testing/sysfs-bus-fpga-dfl > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-dfl b/Documentation/ABI/testing/sysfs-bus-dfl > > > deleted file mode 100644 > > > index 23543be..0000000 > > > --- a/Documentation/ABI/testing/sysfs-bus-dfl > > > +++ /dev/null > > > @@ -1,15 +0,0 @@ > > > -What: /sys/bus/dfl/devices/dfl_dev.X/type > > > -Date: Aug 2020 > > > -KernelVersion: 5.10 > > > -Contact: Xu Yilun > > > -Description: Read-only. It returns type of DFL FIU of the device. Now DFL > > > - supports 2 FIU types, 0 for FME, 1 for PORT. > > > - Format: 0x%x > > > - > > > -What: /sys/bus/dfl/devices/dfl_dev.X/feature_id > > > -Date: Aug 2020 > > > -KernelVersion: 5.10 > > > -Contact: Xu Yilun > > > -Description: Read-only. It returns feature identifier local to its DFL FIU > > > - type. > > > - Format: 0x%x > > > > You're changing userland facing ABI. I think that's something to avoid, > > please check with Greg on the rules since this hasn't been in a release yet. > > > > I'm going to change the name of bus stuff for other subsystems, to be > aligned, I also consider change the bus_type.name and dfl dev_name. But > it will cause the changing of user ABIs. No user case for these user ABI > now cause they are just queued, is it good I change them? Why change the user name here? No need for that, right? Unless you really want to, and think that no one will notice. If so, fine, change them :) > It is mentioned that although Device Feature List is introduced in FPGA, > but it doesn't limit the usage in FPGA only. It's just a method to > discover features from a device, for sure it can be extended and used > in other devices too. So it can be bigger namespace than FPGA. Like in > our existing code, we picked dfl_fpga (DFL based FPGA) for uapi (ioctl) > and internal functions. This is suggested by Alan (The previous FPGA > maintainer). It's possible to have "DFL based XXX" in the future, even > currently only FPGA uses DFL. This is the reason we thought just "dfl" > in the whole kernel space is OK. > So, is there a chance we keep the "dfl" naming in the whole kernel? No one knows what "DFL" is, and odds are, if a different subsystem wants to use it, they will have their own variant, right? And why didn't you all use device tree? How did this sneak in past everyone? thanks, greg k-h