From: Christoph Hellwig <hch@infradead.org>
To: Ethan Zhao <haifeng.zhao@intel.com>
Cc: bhelgaas@google.com, oohall@gmail.com, ruscur@russell.cc,
lukas@wunner.de, andriy.shevchenko@linux.intel.com,
stuart.w.hayes@gmail.com, mr.nuke.me@gmail.com,
mika.westerberg@linux.intel.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, pei.p.jia@intel.com,
ashok.raj@linux.intel.com, sathyanarayanan.kuppuswamy@intel.com
Subject: Re: [PATCH 1/5 V2] PCI: define a function to check and wait till port finish DPC handling
Date: Sun, 27 Sep 2020 07:23:59 +0100 [thread overview]
Message-ID: <20200927062359.GA23452@infradead.org> (raw)
In-Reply-To: <20200927032829.11321-2-haifeng.zhao@intel.com>
> +#ifdef CONFIG_PCIE_DPC
> +static inline bool pci_wait_port_outdpc(struct pci_dev *pdev)
> +{
> + u16 cap = pdev->dpc_cap, status;
> + u16 loop = 0;
> +
> + if (!cap) {
> + pci_WARN_ONCE(pdev, !cap, "No DPC capability initiated\n");
> + return false;
> + }
> + pci_read_config_word(pdev, cap + PCI_EXP_DPC_STATUS, &status);
> + pci_dbg(pdev, "DPC status %x, cap %x\n", status, cap);
> + while (status & PCI_EXP_DPC_STATUS_TRIGGER && loop < 100) {
> + msleep(10);
> + loop++;
> + pci_read_config_word(pdev, cap + PCI_EXP_DPC_STATUS, &status);
> + }
> + if (!(status & PCI_EXP_DPC_STATUS_TRIGGER)) {
> + pci_dbg(pdev, "Out of DPC %x, cost %d ms\n", status, loop*10);
> + return true;
> + }
> + pci_dbg(pdev, "Timeout to wait port out of DPC status\n");
> + return false;
> +}
I don't think that there is any good reason to have this as an
inline function.
next prev parent reply other threads:[~2020-09-27 6:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 3:28 [PATCH 0/5 V2] Fix DPC hotplug race and enhance error handling Ethan Zhao
2020-09-27 3:28 ` [PATCH 1/5 V2] PCI: define a function to check and wait till port finish DPC handling Ethan Zhao
2020-09-27 6:23 ` Christoph Hellwig [this message]
2020-09-27 6:43 ` Zhao, Haifeng
2020-09-29 2:32 ` Ethan Zhao
2020-09-27 3:28 ` [PATCH 2/5 V2] PCI: pciehp: check and wait port status out of DPC before handling DLLSC and PDC Ethan Zhao
2020-09-27 15:27 ` Sinan Kaya
2020-09-28 2:01 ` Zhao, Haifeng
2020-09-28 11:10 ` Sinan Kaya
2020-09-28 16:43 ` Sinan Kaya
2020-09-28 16:44 ` Kuppuswamy, Sathyanarayanan
2020-09-29 2:28 ` Ethan Zhao
2020-09-29 2:50 ` Ethan Zhao
2020-09-29 8:18 ` Lukas Wunner
2020-09-29 9:46 ` Ethan Zhao
2020-09-29 10:07 ` Lukas Wunner
2020-09-30 2:20 ` Ethan Zhao
2020-09-27 3:28 ` [PATCH 3/5 V2] PCI/ERR: get device before call device driver to avoid NULL pointer reference Ethan Zhao
2020-09-27 3:28 ` [PATCH 4/5 V2] PCI: only return true when dev io state is really changed Ethan Zhao
2020-09-27 4:16 ` Joe Perches
2020-09-27 5:12 ` Zhao, Haifeng
2020-09-27 3:28 ` [PATCH 5/5 V2] PCI/ERR: don't mix io state not changed and no driver together Ethan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200927062359.GA23452@infradead.org \
--to=hch@infradead.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ashok.raj@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=haifeng.zhao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=mr.nuke.me@gmail.com \
--cc=oohall@gmail.com \
--cc=pei.p.jia@intel.com \
--cc=ruscur@russell.cc \
--cc=sathyanarayanan.kuppuswamy@intel.com \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox