Re: [PATCH leds v2 03/50] leds: fsg: compile if COMPILE_TEST=y

Pavel Machek
2020-09-19T09:56:21Z

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

On Fri 2020-09-18 00:32:51, Marek Behún wrote:
> This driver can be compiled on other platforms with small change if
> COMPILE_TEST=y.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>

> +++ b/drivers/leds/leds-fsg.c
> @@ -16,7 +16,13 @@
> #include <linux/leds.h>
> #include <linux/module.h>
> #include <linux/io.h>
> +
> +#if IS_ENABLED(MACH_FSG)
> #include <mach/hardware.h>
> +#else
> +/* for COMPILE_TEST */
> +#define IXP4XX_EXP_BUS_BASE(x) (0x12345678 + (x))
> +#endif

This is _way_ too ugly and I'd have to read the driver to understand
what prevents it from using this address and corrupting something, somewhere.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]