From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2956EC2D0A8 for ; Mon, 28 Sep 2020 23:20:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D57B9206BE for ; Mon, 28 Sep 2020 23:20:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601335233; bh=MZv602zAH+mldtKaHV8n2x/vl5hO6z6CgNiDtNb/co4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=MfBZ/vAKdRmyO8blnsSw7rb+7T9y7URxronzcpsc8eDqaVzOJ3D/yCZJrCpC5MI64 VxHnIxEjQHKIRJ7XfCOCbGsyHQAxXq+BRhwlj+ef32t2ysd3asiGWhR23CpHxZMW0z ZEKfjYcXOdOKzwr80SzxH5PgGa71qxQBFufYCuwk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727149AbgI1XUc (ORCPT ); Mon, 28 Sep 2020 19:20:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:42848 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726379AbgI1XUc (ORCPT ); Mon, 28 Sep 2020 19:20:32 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F62721D7F; Mon, 28 Sep 2020 22:01:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601330488; bh=MZv602zAH+mldtKaHV8n2x/vl5hO6z6CgNiDtNb/co4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=10JFGv45YDJTrlFEV6WQiTAi/TskPMzQj6c6xbeq9coOe6pfxGYK0il/SvxLwNFVy ilsp7OakST5z753hMgoeauIJjW/hdokg8folEDFOfyRy6IK6iooE4J7OMx5EhT2IH7 vAD/K7NxbXL/8L1GL3xPWfzt2zHTf9nv6NuiV0QU= Date: Mon, 28 Sep 2020 18:01:27 -0400 From: Sasha Levin To: Naresh Kamboju Cc: linux- stable , Arnaldo Carvalho de Melo , open list , Ian Rogers , Adrian Hunter , Alexander Shishkin , Andi Kleen , clang-built-linux@googlegroups.com, Jiri Olsa , Leo Yan , Mark Rutland , Namhyung Kim , Peter Zijlstra , Stephane Eranian , lkft-triage@lists.linaro.org Subject: Re: [PATCH AUTOSEL 4.14 112/127] perf parse-events: Fix incorrect conversion of 'if () free()' to 'zfree()' Message-ID: <20200928220127.GE2219727@sasha-vm> References: <20200918021220.2066485-1-sashal@kernel.org> <20200918021220.2066485-112-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2020 at 01:24:32AM +0530, Naresh Kamboju wrote: >On Fri, 18 Sep 2020 at 08:00, Sasha Levin wrote: >> >> From: Arnaldo Carvalho de Melo >> >> [ Upstream commit 7fcdccd4237724931d9773d1e3039bfe053a6f52 ] >> >> When applying a patch by Ian I incorrectly converted to zfree() an >> expression that involved testing some other struct member, not the one >> being freed, which lead to bugs reproduceable by: >> >> $ perf stat -e i/bs,tsc,L2/o sleep 1 >> WARNING: multiple event parsing errors >> Segmentation fault (core dumped) >> $ >> >> Fix it by restoring the test for pos->free_str before freeing >> pos->val.str, but continue using zfree(&pos->val.str) to set that member >> to NULL after freeing it. >> >> Reported-by: Ian Rogers >> Fixes: e8dfb81838b1 ("perf parse-events: Fix memory leaks found on parse_events") >> Cc: Adrian Hunter >> Cc: Alexander Shishkin >> Cc: Andi Kleen >> Cc: clang-built-linux@googlegroups.com >> Cc: Jiri Olsa >> Cc: Leo Yan >> Cc: Mark Rutland >> Cc: Namhyung Kim >> Cc: Peter Zijlstra >> Cc: Stephane Eranian >> Signed-off-by: Arnaldo Carvalho de Melo >> Signed-off-by: Sasha Levin > >stable rc 4.14 perf build broken. Dropped, thanks! -- Thanks, Sasha