From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86147C2D0A8 for ; Mon, 28 Sep 2020 23:31:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 469C121BE5 for ; Mon, 28 Sep 2020 23:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601335882; bh=t/gqVVZ5mGy9IlnTbefUgbR40JQ3SrpJIj/iORocWK4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=kRdxTMfUm7qEFV07NZhKUrOOVLatfO6UpaiwMDRuhsDoKsdgmZ+M0KC8yARLYLxbH ToMMzDa9SweEUNYUg8KvBBA0H8k/tlVP07GpssWQcvKUXnKBwyPAJxrj8zmRYa7CfJ 6hb5lNAxqfU0/pJUxczfNdKUzaiby4YrpMejB+1k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727293AbgI1XbU (ORCPT ); Mon, 28 Sep 2020 19:31:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:54528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727258AbgI1XbM (ORCPT ); Mon, 28 Sep 2020 19:31:12 -0400 Received: from paulmck-ThinkPad-P72.home (unknown [50.45.173.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C44622204; Mon, 28 Sep 2020 23:31:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601335867; bh=t/gqVVZ5mGy9IlnTbefUgbR40JQ3SrpJIj/iORocWK4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KcVwDQdlToEnOTkLtZWnFNLi/E8IQtBr2As6rwuI/O5t1OuC2GnkwCLxBmi5NLslg cmYTdAZ9dWaEsfRkfhj/06Ynf9jjvJyCcPGVd7NFd7YOocOeIjrm6S7iEzJlcIRoKV Y9hShA2J9Z22Wkt0nNewdlPoGtDcELbPHAh5c1iw= From: paulmck@kernel.org To: rcu@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, mingo@kernel.org, jiangshanlai@gmail.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, mhocko@kernel.org, mgorman@techsingularity.net, torvalds@linux-foundation.org, kernel test robot , Julia Lawall , "Paul E . McKenney" Subject: [PATCH tip/core/rcu 15/15] kvfree_rcu(): Fix ifnullfree.cocci warnings Date: Mon, 28 Sep 2020 16:31:02 -0700 Message-Id: <20200928233102.24265-15-paulmck@kernel.org> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20200928233041.GA23230@paulmck-ThinkPad-P72> References: <20200928233041.GA23230@paulmck-ThinkPad-P72> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot NULL check before kfree is not needed. Generated by: scripts/coccinelle/free/ifnullfree.cocci Fixes: 9f7e887e648c ("rcu/tree: Allocate a page when caller is preemptible") Acked-by: Joel Fernandes (Google) Signed-off-by: kernel test robot Signed-off-by: Julia Lawall Signed-off-by: Paul E. McKenney --- kernel/rcu/tree.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index cc998d7..4a85ea2 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -3165,8 +3165,7 @@ static void kfree_rcu_work(struct work_struct *work) bkvhead[i] = NULL; krc_this_cpu_unlock(krcp, flags); - if (bkvhead[i]) - kfree(bkvhead[i]); + kfree(bkvhead[i]); cond_resched_tasks_rcu_qs(); } -- 2.9.5