From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C71F4C4727F for ; Tue, 29 Sep 2020 01:32:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 820B9216C4 for ; Tue, 29 Sep 2020 01:32:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601343170; bh=krMwwb9kglF5rmiiF6Q1YgXrmnRlIkkhZ1zwowzi0ps=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Sl0om3Tqf5PGrirISEUUh4tvfFBMkWZpExgbvywtlV0MS8adR17K0lfs7Fp7vRHxX 2KcnV9GAYtfHc4aTytoeCzx5TQ7kfRTicTKkKLR7gBIC+8+kkF7Wgn+hxAJW36SF81 6Wucg0Mcj3N81tYz44tieJfTeS4FqtigCl6flvU0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727902AbgI2Bco (ORCPT ); Mon, 28 Sep 2020 21:32:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:41832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727790AbgI2BcL (ORCPT ); Mon, 28 Sep 2020 21:32:11 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95B8F2075A; Tue, 29 Sep 2020 01:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601343128; bh=krMwwb9kglF5rmiiF6Q1YgXrmnRlIkkhZ1zwowzi0ps=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UK4XLpfsnCJTK6YrLRoVB0Eg/MsmTbN7Tt1nzTV/M1WdjGkQP/HBU/whgrjiM4YLF q70LlBSEcUTkbTciRNKgfdba4bVvt2xrWsMB64+zjy3YuwFY5x/4QhHcAEwfhecK+m Bg8hQBT3UfxJLuWktZ3UIMfcyYwklRU4osHe/Vuw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Olympia Giannou , Olympia Giannou , "David S . Miller" , Sasha Levin , linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 2/4] rndis_host: increase sleep time in the query-response loop Date: Mon, 28 Sep 2020 21:32:03 -0400 Message-Id: <20200929013205.2407201-2-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200929013205.2407201-1-sashal@kernel.org> References: <20200929013205.2407201-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Olympia Giannou [ Upstream commit 4202c9fdf03d79dedaa94b2c4cf574f25793d669 ] Some WinCE devices face connectivity issues via the NDIS interface. They fail to register, resulting in -110 timeout errors and failures during the probe procedure. In this kind of WinCE devices, the Windows-side ndis driver needs quite more time to be loaded and configured, so that the linux rndis host queries to them fail to be responded correctly on time. More specifically, when INIT is called on the WinCE side - no other requests can be served by the Client and this results in a failed QUERY afterwards. The increase of the waiting time on the side of the linux rndis host in the command-response loop leaves the INIT process to complete and respond to a QUERY, which comes afterwards. The WinCE devices with this special "feature" in their ndis driver are satisfied by this fix. Signed-off-by: Olympia Giannou Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/rndis_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c index 524a47a281207..b20b380d91bf6 100644 --- a/drivers/net/usb/rndis_host.c +++ b/drivers/net/usb/rndis_host.c @@ -213,7 +213,7 @@ int rndis_command(struct usbnet *dev, struct rndis_msg_hdr *buf, int buflen) dev_dbg(&info->control->dev, "rndis response error, code %d\n", retval); } - msleep(20); + msleep(40); } dev_dbg(&info->control->dev, "rndis response timeout\n"); return -ETIMEDOUT; -- 2.25.1