Re: [PATCH 1/3] mfd: intel_pmt: Add OOBMSM device ID

David E. Box
2020-09-29T18:19:25Z

On Tue, 2020-09-29 at 10:51 +0100, Lee Jones wrote:
> On Fri, 11 Sep 2020, David E. Box wrote:
>
> > Add Out of Band Management Services Module device ID to Intel PMT
> > driver.
> >
> > Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> > ---
> > drivers/mfd/intel_pmt.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/mfd/intel_pmt.c b/drivers/mfd/intel_pmt.c
> > index 0e572b105101..8f9970ab3026 100644
> > --- a/drivers/mfd/intel_pmt.c
> > +++ b/drivers/mfd/intel_pmt.c
> > @@ -55,6 +55,8 @@ struct pmt_platform_info {
> > unsigned long quirks;
> > };
> >
> > +static const struct pmt_platform_info pmt_info;
> > +
> > static const struct pmt_platform_info tgl_info = {
> > .quirks = PMT_QUIRK_NO_WATCHER | PMT_QUIRK_NO_CRASHLOG |
> > PMT_QUIRK_TABLE_SHIFT,
> > @@ -200,8 +202,10 @@ static void pmt_pci_remove(struct pci_dev
> > *pdev)
> > pm_runtime_get_sync(&pdev->dev);
> > }
> >
> > +#define PCI_DEVICE_ID_INTEL_PMT_OOBMSM 0x09a7
> > #define PCI_DEVICE_ID_INTEL_PMT_TGL 0x9a0d
> > static const struct pci_device_id pmt_pci_ids[] = {
> > + { PCI_DEVICE_DATA(INTEL, PMT_OOBMSM, &pmt_info) },
>
> Why are you supplying an empty struct?

Because the OOBMSM device doesn't need code provided driver data, but
info is dereferenced in several areas. We also use kmemdup to copy
driver_data under the assumption that it was provided. We could allow
for NULL if driver_data is referenced directly.

David