From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5672FC4727C for ; Tue, 29 Sep 2020 12:48:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECA9820C09 for ; Tue, 29 Sep 2020 12:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601383687; bh=v77OFaG2P2gwceHgFCMKAJVT9dd+f6dWbjMdSsqoFEU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WuuhHHq5QEv4Lki8Gcl2ubjotE/kX1GG5ZZUhr6ymWQdeVqnlXv46WVTs/YhB6rAr J0W0pPPMJCpb2HZtv8OQheRQG40ftx6I+xEdUpRWkOTYb3lVjMBouwDVFSTv1kAVSE 3EvKJlXaTdBQO4PWgOkK3Ryi7dwcIf7MyM6ngCMc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387547AbgI2MsE (ORCPT ); Tue, 29 Sep 2020 08:48:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:39162 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728383AbgI2LD1 (ORCPT ); Tue, 29 Sep 2020 07:03:27 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8CB021924; Tue, 29 Sep 2020 11:03:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601377407; bh=v77OFaG2P2gwceHgFCMKAJVT9dd+f6dWbjMdSsqoFEU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yY1dviCjv76deMD6xI6KOAN1sXEz5KyJ1llwuX4wV/DV03Oi9vvBBAkmcEsbB4ZIA BpxUy2uYXeAbu2NR3eGLz6kRSWw7BQ/LXz0UGizE6BYjNpbyNdSek5KerAfw2lHADD 8Iib2JJJtwErCU0Ruwk2JEv5RrPljU+RrBW/cFSs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vasily Averin , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 24/85] rt_cpu_seq_next should increase position index Date: Tue, 29 Sep 2020 12:59:51 +0200 Message-Id: <20200929105929.436621788@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929105928.198942536@linuxfoundation.org> References: <20200929105928.198942536@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Averin [ Upstream commit a3ea86739f1bc7e121d921842f0f4a8ab1af94d9 ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/ipv4/route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 542f6e0f438f1..ea1c319100a5d 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -271,6 +271,7 @@ static void *rt_cpu_seq_next(struct seq_file *seq, void *v, loff_t *pos) *pos = cpu+1; return &per_cpu(rt_cache_stat, cpu); } + (*pos)++; return NULL; } -- 2.25.1