From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Scott Branden <scott.branden@broadcom.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v4 01/16] bcm-vk: add bcm_vk UAPI
Date: Tue, 29 Sep 2020 19:08:56 +0200 [thread overview]
Message-ID: <20200929170856.GA1351851@kroah.com> (raw)
In-Reply-To: <e8159e9d-0c8e-e494-407a-f4cde7c5015f@broadcom.com>
On Tue, Sep 29, 2020 at 09:44:51AM -0700, Scott Branden wrote:
>
>
> On 2020-09-29 3:25 a.m., Greg Kroah-Hartman wrote:
> > On Mon, Sep 28, 2020 at 05:11:54PM -0700, Scott Branden wrote:
> >> Add user space api for bcm-vk driver.
> >>
> >> Provide ioctl api to load images and issue reset command to card.
> >> FW status registers in PCI BAR space also defined as part
> >> of API so that user space is able to interpret these memory locations
> >> as needed via direct PCIe access.
> >>
> >> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
> >> ---
> >> include/uapi/linux/misc/bcm_vk.h | 84 ++++++++++++++++++++++++++++++++
> >> 1 file changed, 84 insertions(+)
> >> create mode 100644 include/uapi/linux/misc/bcm_vk.h
> >>
> >> diff --git a/include/uapi/linux/misc/bcm_vk.h b/include/uapi/linux/misc/bcm_vk.h
> >> new file mode 100644
> >> index 000000000000..5f1fc403bc67
> >> --- /dev/null
> >> +++ b/include/uapi/linux/misc/bcm_vk.h
> >> @@ -0,0 +1,84 @@
> >> +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) */
> > Why do you need BSD-2 if you already have the syscall-note license?
> We include the header file outside of linux user space and use the defines in BSD and other code.
> Hence releasing the header as BSD-2 as well.
Are you _sure_ you need that extra license? I ask as this is not the
"norm" for Linux api .h files.
Also note, given that you are the copyright holder, you can provide a
version in any other license in any other project, no need to put it
here.
I recommend going and talking to your license lawyers about this.
thanks,
greg k-h
next prev parent reply other threads:[~2020-09-29 17:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 0:11 [PATCH v4 00/16] Add Broadcom VK driver Scott Branden
2020-09-29 0:11 ` [PATCH v4 01/16] bcm-vk: add bcm_vk UAPI Scott Branden
2020-09-29 10:25 ` Greg Kroah-Hartman
2020-09-29 16:44 ` Scott Branden
2020-09-29 17:08 ` Greg Kroah-Hartman [this message]
2020-09-29 17:38 ` Scott Branden
2020-09-29 0:11 ` [PATCH v4 02/16] misc: bcm-vk: add Broadcom VK driver Scott Branden
2020-09-29 10:28 ` Greg Kroah-Hartman
2020-09-29 23:51 ` Scott Branden
2020-09-29 0:11 ` [PATCH v4 03/16] misc: bcm-vk: add autoload support Scott Branden
2020-09-29 0:11 ` [PATCH v4 04/16] misc: bcm-vk: add misc device to Broadcom VK driver Scott Branden
2020-09-29 0:11 ` [PATCH v4 05/16] misc: bcm-vk: add triggers when host panic or reboots to notify card Scott Branden
2020-09-29 0:11 ` [PATCH v4 06/16] misc: bcm-vk: add ttyVK support Scott Branden
2020-09-29 10:32 ` Greg Kroah-Hartman
2020-09-29 21:45 ` Scott Branden
2020-09-29 0:12 ` [PATCH v4 07/16] misc: bcm-vk: add open/release Scott Branden
2020-09-29 0:12 ` [PATCH v4 08/16] misc: bcm-vk: add ioctl load_image Scott Branden
2020-09-29 0:12 ` [PATCH v4 09/16] misc: bcm-vk: add get_card_info, peerlog_info, and proc_mon_info Scott Branden
2020-09-29 0:12 ` [PATCH v4 10/16] misc: bcm-vk: add VK messaging support Scott Branden
2020-09-29 0:12 ` [PATCH v4 11/16] misc: bcm-vk: reset_pid support Scott Branden
2020-09-29 0:12 ` [PATCH v4 12/16] misc: bcm-vk: add BCM_VK_QSTATS Scott Branden
2020-09-29 0:12 ` [PATCH v4 13/16] misc: bcm-vk: add tty irq handler Scott Branden
2020-09-29 0:12 ` [PATCH v4 14/16] misc: bcm-vk: add sysfs interface Scott Branden
2020-09-29 0:12 ` [PATCH v4 15/16] misc: bcm-vk: add mmap function for exposing BAR2 Scott Branden
2020-09-29 0:12 ` [PATCH v4 16/16] MAINTAINERS: bcm-vk: add maintainer for Broadcom VK Driver Scott Branden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929170856.GA1351851@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scott.branden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox