From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 198B9C2D0A8 for ; Wed, 30 Sep 2020 06:22:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA77220789 for ; Wed, 30 Sep 2020 06:22:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601446976; bh=EXxvDUn4XGcHD/Ca0uIvwF+PRWacJD69F4bcem0AxSw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=MsY0KRSsmh2lP2AiOk5okLpUqV1kRQxpL2WqHrFi5mzcblt8gj7AoYRXaHC6mJC6Y dFw7RdVvsOPIMkuJoOaSHXrhz6X7tYtS7AaXkBdJ9EE7429k5nxHYYZziBhUoHxatK IPCrwHPLgI2N3+TtOESiXNiS4yRPjoid4IsOtxsY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727841AbgI3GWz (ORCPT ); Wed, 30 Sep 2020 02:22:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:47976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725320AbgI3GWz (ORCPT ); Wed, 30 Sep 2020 02:22:55 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E6772075A; Wed, 30 Sep 2020 06:22:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601446974; bh=EXxvDUn4XGcHD/Ca0uIvwF+PRWacJD69F4bcem0AxSw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cehjbcseNzUjHSH9H/NUjRZOIUzHKfq3q9Ty7fj3LwMusdc294CGdNFS7gdzKtiiK WI3Y6zw4SOZB4Y+SdZFlplaofN7HquwtrvQZ+Gb1v7JjPvLnN0MAysxbZB2TYeExGL zOFWw3q77zfFM0MabdV5ksP31I3MmAp6bGMxarjQ= Date: Wed, 30 Sep 2020 08:22:58 +0200 From: Greg Kroah-Hartman To: Thomas Gleixner Cc: LKML , Peter Zijlstra , Paul McKenney , Matthew Wilcox , Christian Benvenuti , Govindarajulu Varadarajan <_govind@gmx.com>, Dave Miller , Jakub Kicinski , netdev@vger.kernel.org, Jonathan Corbet , Mauro Carvalho Chehab , linux-doc@vger.kernel.org, Sebastian Andrzej Siewior , Luc Van Oostenryck , Jay Cliburn , Chris Snook , Vishal Kulkarni , Jeff Kirsher , intel-wired-lan@lists.osuosl.org, Shannon Nelson , Pensando Drivers , Andrew Lunn , Heiner Kallweit , Russell King , Thomas Bogendoerfer , Solarflare linux maintainers , Edward Cree , Martin Habets , Jon Mason , Daniel Drake , Ulrich Kunitz , Kalle Valo , linux-wireless@vger.kernel.org, linux-usb@vger.kernel.org, Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, Stanislav Yakovlev , Stanislaw Gruszka , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Jouni Malinen , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , libertas-dev@lists.infradead.org, Pascal Terjan , Ping-Ke Shih Subject: Re: [patch V2 21/36] net: usb: kaweth: Replace kaweth_control() with usb_control_msg() Message-ID: <20200930062258.GA1471881@kroah.com> References: <20200929202509.673358734@linutronix.de> <20200929203501.588965483@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200929203501.588965483@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2020 at 10:25:30PM +0200, Thomas Gleixner wrote: > From: Sebastian Andrzej Siewior > > kaweth_control() is almost the same as usb_control_msg() except for the > memory allocation mode (GFP_ATOMIC vs GFP_NOIO) and the in_interrupt() > check. > > All the invocations of kaweth_control() are within the probe function in > fully preemtible context so there is no reason to use atomic allocations, > GFP_NOIO which is used by usb_control_msg() is perfectly fine. > > Replace kaweth_control() invocations from probe with usb_control_msg(). > > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner Note, the usb_control_msg_send/recv() new functions that will show up in 5.10-rc1 will help a bit with this logic, but for what you have now, this is fine, nice cleanups. Reviewed-by: Greg Kroah-Hartman