Re: [PATCH v5 2/3] remoteproc: qcom: Add capability to collect minidumps

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3340 bytes --]

Hi Siddharth,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.9-rc7 next-20200929]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Siddharth-Gupta/Introduce-mini-dump-support-for-remoteproc/20200925-075245
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 171d4ff79f965c1f164705ef0aaea102a6ad238b
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/cc292eb63f7fe2d3007889428362b160e8854e9e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Siddharth-Gupta/Introduce-mini-dump-support-for-remoteproc/20200925-075245
        git checkout cc292eb63f7fe2d3007889428362b160e8854e9e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/remoteproc/qcom_q6v5_pas.c: In function 'adsp_add_minidump_segments':
>> drivers/remoteproc/qcom_q6v5_pas.c:151:9: error: implicit declaration of function '__raw_readq'; did you mean '__raw_readl'? [-Werror=implicit-function-declaration]
     151 |    da = __raw_readq(&region_info->region_base_address);
         |         ^~~~~~~~~~~
         |         __raw_readl
   cc1: some warnings being treated as errors

vim +151 drivers/remoteproc/qcom_q6v5_pas.c

   123	
   124	static void adsp_add_minidump_segments(struct rproc *rproc, struct md_ss_toc *minidump_ss)
   125	{
   126		struct md_ss_region __iomem *region_info;
   127		int seg_cnt = 0, i;
   128		void __iomem *ptr;
   129		dma_addr_t da;
   130		size_t size;
   131		char *name;
   132	
   133		seg_cnt = minidump_ss->ss_region_count;
   134		ptr = ioremap((unsigned long)minidump_ss->md_ss_smem_regions_baseptr,
   135			      seg_cnt * sizeof(struct md_ss_region));
   136	
   137		if (!ptr)
   138			return;
   139	
   140		region_info = ptr;
   141	
   142		if (!list_empty(&rproc->dump_segments)) {
   143			dev_info(&rproc->dev, "dump segment list already populated\n");
   144			goto unmap_iomem;
   145		}
   146	
   147		for (i = 0; i < seg_cnt; i++) {
   148			if (__raw_readl(&region_info->md_valid) == MD_REGION_VALID) {
   149				name = kmalloc(MAX_REGION_NAME_LENGTH, GFP_KERNEL);
   150				memcpy_fromio(name, region_info->name, sizeof(region_info->name));
 > 151				da = __raw_readq(&region_info->region_base_address);
   152				size = __raw_readq(&region_info->region_size);
   153				rproc_coredump_add_custom_segment(rproc, da, size, NULL, name);
   154			}
   155			region_info++;
   156		}
   157	
   158	unmap_iomem:
   159		iounmap(ptr);
   160	}
   161	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 76056 bytes --]