From: Mark Brown <broonie@kernel.org>
To: ChiYuan Huang <u0084500@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
cy_huang <cy_huang@richtek.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] regulator: rtmv20: Add DT-binding document for Richtek RTMV20
Date: Wed, 30 Sep 2020 10:42:24 +0100 [thread overview]
Message-ID: <20200930094224.GA4974@sirena.org.uk> (raw)
In-Reply-To: <CADiBU3_7wj7W2evOAG1GM991OigPYy4FXraeOLCVreaMO86HXw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
On Wed, Sep 30, 2020 at 10:23:49AM +0800, ChiYuan Huang wrote:
> Due to that already merged into your regulator for-next git, may I
> send the patch to fix Rob's comment?
Of course, yes please.
> And I also found one line need to be added into rtmv20 probe phase.
> Please check below.
> /*
> * keep in shutdown mode to minimize the current consumption
> * and also mark regcache as dirty
> */
> + regcache_cache_only(priv->regmap, true);
> regcache_mark_dirty(priv->regmap);
> gpiod_set_value(priv->enable_gpio, 0);
>
> Can I directly merge into one that includes Rob's comment and the
> above line to be added?
Please make it a separate patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-30 9:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 7:19 [PATCH v2 1/2] regulator: rtmv20: Adds support for Richtek RTMV20 load switch regulator cy_huang
2020-09-28 7:19 ` [PATCH v2 2/2] regulator: rtmv20: Add DT-binding document for Richtek RTMV20 cy_huang
2020-09-29 15:06 ` Rob Herring
2020-09-30 2:23 ` ChiYuan Huang
2020-09-30 9:42 ` Mark Brown [this message]
2020-09-30 10:02 ` ChiYuan Huang
2020-09-28 19:35 ` [PATCH v2 1/2] regulator: rtmv20: Adds support for Richtek RTMV20 load switch regulator Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930094224.GA4974@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox