public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Egorenkov <egorenar@linux.ibm.com>
To: dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com, lijiang@redhat.com
Cc: ebiederm@xmission.com, akpm@linux-foundation.org,
	ktkhai@virtuozzo.com, keescook@chromium.org,
	christian.brauner@ubuntu.com, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Alexander Egorenkov <egorenar@linux.ibm.com>
Subject: [PATCH v3 1/1] kdump: append uts_namespace.name offset to VMCOREINFO
Date: Wed, 30 Sep 2020 12:23:28 +0200	[thread overview]
Message-ID: <20200930102328.396488-1-egorenar@linux.ibm.com> (raw)

The offset of the field 'init_uts_ns.name' has changed
since commit 9a56493f6942 ("uts: Use generic ns_common::count").

Link: https://lore.kernel.org/r/159644978167.604812.1773586504374412107.stgit@localhost.localdomain

Make the offset of the field 'uts_namespace.name' available
in VMCOREINFO because tools like 'crash-utility' and
'makedumpfile' must be able to read it from crash dumps.

Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com>
---

v2 -> v3:
 * Added documentation to vmcoreinfo.rst
 * Use the short form of the commit reference

v1 -> v2:
 * Improved commit message
 * Added link to the discussion of the uts namespace changes

 Documentation/admin-guide/kdump/vmcoreinfo.rst | 6 ++++++
 kernel/crash_core.c                            | 1 +
 2 files changed, 7 insertions(+)

diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst
index e44a6c01f336..3861a25faae1 100644
--- a/Documentation/admin-guide/kdump/vmcoreinfo.rst
+++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst
@@ -39,6 +39,12 @@ call.
 User-space tools can get the kernel name, host name, kernel release
 number, kernel version, architecture name and OS type from it.
 
+(uts_namespace, name)
+---------------------
+
+Offset of the name's member. Crash Utility and Makedumpfile get
+the start address of the init_uts_ns.name from this.
+
 node_online_map
 ---------------
 
diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index 106e4500fd53..173fdc261882 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)
 	VMCOREINFO_PAGESIZE(PAGE_SIZE);
 
 	VMCOREINFO_SYMBOL(init_uts_ns);
+	VMCOREINFO_OFFSET(uts_namespace, name);
 	VMCOREINFO_SYMBOL(node_online_map);
 #ifdef CONFIG_MMU
 	VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir);
-- 
2.26.2


             reply	other threads:[~2020-09-30 10:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 10:23 Alexander Egorenkov [this message]
2020-10-02  2:38 ` [PATCH v3 1/1] kdump: append uts_namespace.name offset to VMCOREINFO lijiang
2020-10-20  2:28 ` Baoquan He
2021-01-08  3:32 ` Baoquan He
2021-01-08  8:12   ` Greg KH
2021-01-08  8:48     ` Baoquan He
2021-01-08 10:07   ` HAGIO KAZUHITO(萩尾 一仁)
2021-01-08 10:22     ` Baoquan He
2021-01-11  9:16       ` gregkh
2021-01-11 10:03         ` Baoquan He
2021-01-11  9:13   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200930102328.396488-1-egorenar@linux.ibm.com \
    --to=egorenar@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=christian.brauner@ubuntu.com \
    --cc=dyoung@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=keescook@chromium.org \
    --cc=kexec@lists.infradead.org \
    --cc=ktkhai@virtuozzo.com \
    --cc=lijiang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox