Re: [PATCH v2 09/16] hwmon: (mr75203) add VM pre-scalar property for Moortec PVT controller

Guenter Roeck
2022-08-18T20:13:36Z

On Wed, Aug 17, 2022 at 05:43:14AM +0000, Eliav Farber wrote:
> vm-pre-scalar-ch# is a per channel optional parameter that can be
> used to normalzie the voltage output results.
>
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
> .../devicetree/bindings/hwmon/moortec,mr75203.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> index 6111b5069b3c..e2a55001eefc 100644
> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> @@ -56,6 +56,12 @@ properties:
> A value of 0 means that the entire VM sensor is nou used.
> $ref: /schemas/types.yaml#definitions/uint8-array
>
> + vm-pre-scalar-ch#:

Is that how such properties are implemented ? Seems to me that
results in a lot of decode complexity.

Why not use an array property like the other properties ?

Guenter

> + description:
> + vm-active-channels defines the pre-scalar per channel value
> + used to normalzie the voltage output results.
> + $ref: /schemas/types.yaml#definitions/uint32
> +
> required:
> - compatible
> - reg
> @@ -68,6 +74,7 @@ additionalProperties:
> - intel,vm-map
> - reset-control-skip
> - vm-active-channels
> + - vm-pre-scalar-ch#
>
> examples:
> - |
> @@ -82,5 +89,6 @@ examples:
> clocks = <&osc0>;
> resets = <&rcu0 0x40 7>;
> vm-active-channels = [08 10 02];
> + vm-pre-scalar-ch5 = <2>;
> #thermal-sensor-cells = <1>;
> };