Re: [PATCH v2 04/16] hwmon: (mr75203) add Moortec PVT controller reset-control-skip property

Guenter Roeck
2022-08-18T20:07:40Z

On Wed, Aug 17, 2022 at 05:43:09AM +0000, Eliav Farber wrote:
> Adding a "reset-control-skip" bool property to the mr75203 node will
> avoid looking up and obtaining a reference to a reset controller.
>

This seems overly complex. WHy not just declare the "resets"
property optional ?

Guenter

> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
> .../devicetree/bindings/hwmon/moortec,mr75203.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> index f9e849cc73e0..da9c3cdcb6f0 100644
> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> @@ -44,6 +44,11 @@ properties:
> "#thermal-sensor-cells":
> const: 1
>
> + reset-control-skip:
> + description:
> + reset-control-skip bool property defines if obtaining a
> + reference to a reset controller should be skipped.
> +
> required:
> - compatible
> - reg
> @@ -54,6 +59,7 @@ required:
>
> additionalProperties:
> - intel,vm-map
> + - reset-control-skip
>
> examples:
> - |