Re: linux-next: build failure after merge of the hwmon-staging tree

Guenter Roeck
2020-03-22T23:45:08Z

[-- Attachment #1.1: Type: text/plain, Size: 2264 bytes --]

On 3/22/20 4:37 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/hwmon/pmbus/isl68137.c: In function 'raa_dmpvr2_read_word_data':
> drivers/hwmon/pmbus/isl68137.c:125:9: error: too few arguments to function 'pmbus_read_word_data'
> 125 | ret = pmbus_read_word_data(client, page, RAA_DMPVR2_READ_VMON);
> | ^~~~~~~~~~~~~~~~~~~~
> In file included from drivers/hwmon/pmbus/isl68137.c:19:
> drivers/hwmon/pmbus/pmbus.h:466:5: note: declared here
> 466 | int pmbus_read_word_data(struct i2c_client *client, int page, int phase,
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/hwmon/pmbus/isl68137.c: In function 'isl68137_probe':
> drivers/hwmon/pmbus/isl68137.c:199:24: error: assignment to 'int (*)(struct i2c_client *, int, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int)' [-Werror=incompatible-pointer-types]
> 199 | info->read_word_data = raa_dmpvr2_read_word_data;
> | ^
> drivers/hwmon/pmbus/isl68137.c:203:24: error: assignment to 'int (*)(struct i2c_client *, int, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int)' [-Werror=incompatible-pointer-types]
> 203 | info->read_word_data = raa_dmpvr2_read_word_data;
> | ^
> drivers/hwmon/pmbus/isl68137.c:206:24: error: assignment to 'int (*)(struct i2c_client *, int, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int)' [-Werror=incompatible-pointer-types]
> 206 | info->read_word_data = raa_dmpvr2_read_word_data;
> | ^
> drivers/hwmon/pmbus/isl68137.c:216:24: error: assignment to 'int (*)(struct i2c_client *, int, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int)' [-Werror=incompatible-pointer-types]
> 216 | info->read_word_data = raa_dmpvr2_read_word_data;
> | ^
>
> Caused by commit
>
> 96c72647bc37 ("hwmon: (pmbus) add support for 2nd Gen Renesas digital multiphase")
>

Weird, 0day reported build success. Or at least I thought so.
Anyway, fixed.

Guenter

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]