From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 330E2C4727E for ; Thu, 1 Oct 2020 19:49:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5FDB20848 for ; Thu, 1 Oct 2020 19:49:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732711AbgJATtq (ORCPT ); Thu, 1 Oct 2020 15:49:46 -0400 Received: from gate.crashing.org ([63.228.1.57]:34939 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729990AbgJATtq (ORCPT ); Thu, 1 Oct 2020 15:49:46 -0400 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 091Jdd8m014394; Thu, 1 Oct 2020 14:39:39 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 091Jdccq014393; Thu, 1 Oct 2020 14:39:38 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 1 Oct 2020 14:39:37 -0500 From: Segher Boessenkool To: Miguel Ojeda Cc: Joe Perches , Kees Cook , "Paul E . McKenney" , Nick Desaulniers , Lai Jiangshan , Josh Triplett , Steven Rostedt , LKML , rcu@vger.kernel.org, Clang-Built-Linux ML , Mathieu Desnoyers , Sedat Dilek , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo") Message-ID: <20201001193937.GM28786@gate.crashing.org> References: <20200929192549.501516-1-ndesaulniers@google.com> <133589afbe999347454dfcc46ae782897bf9e3a2.camel@perches.com> <46f69161e60b802488ba8c8f3f8bbf922aa3b49b.camel@perches.com> <417ffa3fd3fba5d4a481db6a0b0c9b48cbbb17c4.camel@perches.com> <46040e2776a4848add06126ce1cb8f846709294f.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! On Thu, Oct 01, 2020 at 12:15:39PM +0200, Miguel Ojeda wrote: > > So it looks like the best option is to exclude these > > 2 files from conversion. > > Agreed. Nevertheless, is there any reason arch/powerpc/* should not be > compiling cleanly with compiler.h? (CC'ing the rest of the PowerPC > reviewers and ML). You need to #include compiler_types.h to get this #define? (The twice-defined thing is a warning, not an error. It should be fixed of course, but it is less important; although it may be pointing to a deeper problem.) Segher