From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65BACC4363D for ; Fri, 2 Oct 2020 06:32:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28048206DD for ; Fri, 2 Oct 2020 06:32:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JB6jeYf3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726124AbgJBGcJ (ORCPT ); Fri, 2 Oct 2020 02:32:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726015AbgJBGcJ (ORCPT ); Fri, 2 Oct 2020 02:32:09 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B3E8C0613E3 for ; Thu, 1 Oct 2020 23:32:07 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id x14so433321wrl.12 for ; Thu, 01 Oct 2020 23:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=nPkSNZ+pBwevxbb71PLvut2Zm5obbeYq8dEPZbv1fLQ=; b=JB6jeYf3TH4bCDvi2v7PJFfTEVQfeh95qnmxVETkcD4KyPxHiDEnDXfBz99mR84XOV Qg9WomisRVw2MgqWmJPHjZwawrNriV+xVCtovlfHoe882oURGv1t5j7rbpVMI9ZzTk4G G+JciiS5G0V/dB7YpzPxraJYClGZsf4CTZn06bVOfM9+XArukgFMWq9SFbnz4ONj0D6b RnnQl9XpRKRBispE+qDS30otK4huK9o7m2rzl7BGK0o0r/chAJ0wg7T+EfAYC5e4wXHX od0I+bsEiFXFGJXRW9daiRH7jyM7C+MzFYB3hCbf/Rl5bkWRr1FPLt5bZu/PA5eCGUVY ObRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=nPkSNZ+pBwevxbb71PLvut2Zm5obbeYq8dEPZbv1fLQ=; b=inyMkgy9yAcRgtze50NBB4c6A/kQ+8IhccG5fwJOWZdsXmGVCpVAhXaVIqxPYW/SzH Xr+KhJZoSAZ7/z+Tl+pkP2cpEP4USwE80SlNyfoAIaqrGKANUWQnE152Bgjd55dx5rOd mrA22yDv6megeT/1Q8rn7zhHkW9+DQPrS8DfIz/kgi6s2yJnbXzNSImZM3qnmGuVEPFK vjPRj9mljJwS62gWX1yC8/xMyoHzUZIAhRQPD6MCXKDgnf4/ar+T7BKLtXSVzRsFMPw1 W+SIJ3lwP85QAR3y9KdbZLKrGI55aNmgpszZdIz82dLoyS/MRFZrJdTx1eZY5UzXhRVI Y0fw== X-Gm-Message-State: AOAM5305/vRUSZJq8UEApbe8e1MjYncErzYrSijDmOn0xFz/3SugzTfP GpW/BXtKMnpQ/x+VYyu1dr0+jg== X-Google-Smtp-Source: ABdhPJyYYxY68GzP2ZjS+mHVPKam90OMrF1OAhz1d7NZatnrbA/X0LZohbLqsAl4QuGmAns/WDcvPA== X-Received: by 2002:adf:c3cc:: with SMTP id d12mr1114335wrg.399.1601620325905; Thu, 01 Oct 2020 23:32:05 -0700 (PDT) Received: from dell ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id z83sm611537wmb.4.2020.10.01.23.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 23:32:05 -0700 (PDT) Date: Fri, 2 Oct 2020 07:32:03 +0100 From: Lee Jones To: Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: Tree for Oct 1 (drivers/mfd/simple-mfd-i2c.o) Message-ID: <20201002063203.GP6148@dell> References: <20201001213929.241c1006@canb.auug.org.au> <0dca758e-1b61-a4cd-db12-2e2060f7cf60@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0dca758e-1b61-a4cd-db12-2e2060f7cf60@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 01 Oct 2020, Randy Dunlap wrote: > On 10/1/20 4:39 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20200930: > > > > on x86_64: > > ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe': > simple-mfd-i2c.c:(.text+0x48): undefined reference to `__devm_regmap_init_i2c' > ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_driver_init': > simple-mfd-i2c.c:(.init.text+0x14): undefined reference to `i2c_register_driver' > ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_driver_exit': > simple-mfd-i2c.c:(.exit.text+0xd): undefined reference to `i2c_del_driver' > > > CONFIG_I2C=m > CONFIG_MFD_SIMPLE_MFD_I2C=y > CONFIG_MFD_SL28CPLD=y > > > Is linux-next missing the source code for CONFIG_MFD_SL28CPLD? There isn't any associated source code. It's a virtual symbol. > The build error is caused by: > > config MFD_SL28CPLD > tristate "Kontron sl28cpld Board Management Controller" > select MFD_SIMPLE_MFD_I2C > > that "select" when "depends on I2C" is absent/missing. Okay, so CONFIG_MFD_SIMPLE_MFD_I2C needs to depend on I2C too? I made the assumption that 'select REGMAP_I2C' would do the right thing. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog