From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 998F1C47423 for ; Fri, 2 Oct 2020 06:49:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55CB7206DD for ; Fri, 2 Oct 2020 06:49:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tWXguv2Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726209AbgJBGtw (ORCPT ); Fri, 2 Oct 2020 02:49:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725968AbgJBGtw (ORCPT ); Fri, 2 Oct 2020 02:49:52 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7DD7C0613E2 for ; Thu, 1 Oct 2020 23:49:51 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id x14so477196wrl.12 for ; Thu, 01 Oct 2020 23:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=UoynpyD6AhgXUB6wR1FXtYWnjMZi4vEwFI3CCNbPh/Q=; b=tWXguv2ZF0F5qwrOvcenJ2zOdlhvSJCtiTfazpgPgCUff7y5mZjhcy91c4+YFMJQFs r30J/sQBFQQGHuHftJQldSaD1Up2mzT5VYE143b1Ny7JTtZJUGmGRtB0eeFhZFsWSSdU VFXK+kxDZyob7WTGnDZTD4K08nvWYRegljwj0VAAt0sO3RX03Eq4TXbnh3B97nhZ2GFf zS6u77rCgEG6WPXLkmco018F6NTrS+yeUvgX+DEoEUnSpTy0y9rIJojPpxm4Z9GIcm9s tTOGdi/sEB0xMeuLFLtonRmCGZQjCDvx3uQvR8AN2QBfh2cZjeNQ87gbgOcuO3tdeYkY g/YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=UoynpyD6AhgXUB6wR1FXtYWnjMZi4vEwFI3CCNbPh/Q=; b=dhODXhbYtzaksp0gb0ZuI7mr51m88A1lLKiL/f/2J97Xgzsun0CntrK4M+m4BCwrO1 iweTILqbG7pBJeGabcqDLTyUR+4FRIVuseGbZ7VwAGFKn/C8fX+LJQ6SXv1vbuvr4w86 axwU2gqM6aQTiLOsKhnu0Dvpb6TEYXI14TZeGY9Mrxo8mVlSuNIyyM9al6fUYHaTUZCF ipSDRcC5qdJ/BNoFts71mCqZEVWXoMzpMr9ogIaAMaLj3qmTvDtfJaluaB8oZBoXrlmc JERrGGjybAD7fggQSPyYlNmOnMCYOsj1jujOHdLw8AO+p/0tP9PnXKqHfygIK+o4MV+6 oIyw== X-Gm-Message-State: AOAM531+Xx/lX2UlxN63947NLbYe05deJSaBsBoPmWMT8yN7/wnM5vsw +ZN7nQ8Gyz+t/Zt2h/iC80M+bAjzJefsVg== X-Google-Smtp-Source: ABdhPJwXKvamwY1YeQU9ErKMKhnd33q+LPxo4LI6im24/u+dR6YSHPEn41d7IqdD7pAJjfPLnHbrvQ== X-Received: by 2002:adf:fe42:: with SMTP id m2mr1161269wrs.367.1601621390382; Thu, 01 Oct 2020 23:49:50 -0700 (PDT) Received: from dell ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id v204sm660429wmg.20.2020.10.01.23.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 23:49:49 -0700 (PDT) Date: Fri, 2 Oct 2020 07:49:48 +0100 From: Lee Jones To: Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: Tree for Oct 1 (drivers/mfd/simple-mfd-i2c.o) Message-ID: <20201002064948.GQ6148@dell> References: <20201001213929.241c1006@canb.auug.org.au> <0dca758e-1b61-a4cd-db12-2e2060f7cf60@infradead.org> <20201002063203.GP6148@dell> <5974d448-a704-fd74-704c-b902b0ac9a8f@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5974d448-a704-fd74-704c-b902b0ac9a8f@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 01 Oct 2020, Randy Dunlap wrote: > On 10/1/20 11:32 PM, Lee Jones wrote: > > On Thu, 01 Oct 2020, Randy Dunlap wrote: > > > >> On 10/1/20 4:39 AM, Stephen Rothwell wrote: > >>> Hi all, > >>> > >>> Changes since 20200930: > >>> > >> > >> on x86_64: > >> > >> ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe': > >> simple-mfd-i2c.c:(.text+0x48): undefined reference to `__devm_regmap_init_i2c' > >> ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_driver_init': > >> simple-mfd-i2c.c:(.init.text+0x14): undefined reference to `i2c_register_driver' > >> ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_driver_exit': > >> simple-mfd-i2c.c:(.exit.text+0xd): undefined reference to `i2c_del_driver' > >> > >> > >> CONFIG_I2C=m > >> CONFIG_MFD_SIMPLE_MFD_I2C=y > >> CONFIG_MFD_SL28CPLD=y > >> > >> > >> Is linux-next missing the source code for CONFIG_MFD_SL28CPLD? > > > > There isn't any associated source code. It's a virtual symbol. > > > >> The build error is caused by: > >> > >> config MFD_SL28CPLD > >> tristate "Kontron sl28cpld Board Management Controller" > >> select MFD_SIMPLE_MFD_I2C > >> > >> that "select" when "depends on I2C" is absent/missing. > > > > Okay, so CONFIG_MFD_SIMPLE_MFD_I2C needs to depend on I2C too? I made > > the assumption that 'select REGMAP_I2C' would do the right thing. > > "select" never follows any dependency chains, so Yes, the other symbol > needs to depend on I2C also. Makes sense. Will fix, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog