From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3972CC4727D for ; Fri, 2 Oct 2020 14:52:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 058E920708 for ; Fri, 2 Oct 2020 14:52:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601650362; bh=WC1IjM1NrErdHcH0fVBRGfxgPcBe7vNjf2anh374AFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=MeM7sCltQkov2zIDoqPY0CHZF7qZWdIkpx+bk/vLVYc5dTzbDJhZ6HGfvInPkS80E yE84XjQ2u9aoLNtoLcP6wvvGQlC+JviN1PGRYr2pjeU1vNuTSya6abIM9mbKvbLy7F Edv73iL4aNJeL0CKu8aP++nxHPujwD6ZPOuS7I8A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388268AbgJBOwk (ORCPT ); Fri, 2 Oct 2020 10:52:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:35646 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388115AbgJBOwk (ORCPT ); Fri, 2 Oct 2020 10:52:40 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9FB0420665; Fri, 2 Oct 2020 14:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601650359; bh=WC1IjM1NrErdHcH0fVBRGfxgPcBe7vNjf2anh374AFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vTYaPqHred/cj03AawPeF3+9zWYJ5ZNM6inWBRZq7yYimHIMiGgHQu8cziuSnfEfh MwrQgOz0rbSFExYil8gi90Mg84Wb4NH11qfdSC2FI2IeKu/q7nSF5q+1pbv25SQ0Fj egGRUqEQ7YNEFyKPghs6OHamVonJ0knxrMCkaiWg= Received: by pali.im (Postfix) id 91909E79; Fri, 2 Oct 2020 16:52:37 +0200 (CEST) Date: Fri, 2 Oct 2020 16:52:37 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Lorenzo Pieralisi Cc: Rob Herring , Bjorn Helgaas , Miquel Raynal , Kishon Vijay Abraham I , Vinod Koul , Marek =?utf-8?B?QmVow7pu?= , Tomasz Maciej Nowak , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] PCI: aardvark: Fix comphy with old ATF Message-ID: <20201002145237.r2troxmgbq2bf3ep@pali> References: <20200902144344.16684-1-pali@kernel.org> <20201002133713.GA24425@e121166-lin.cambridge.arm.com> <20201002142616.dxgdneg2lqw4pxie@pali> <20201002143851.GA25575@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201002143851.GA25575@e121166-lin.cambridge.arm.com> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 02 October 2020 15:38:51 Lorenzo Pieralisi wrote: > On Fri, Oct 02, 2020 at 04:26:16PM +0200, Pali Rohár wrote: > > On Friday 02 October 2020 14:37:13 Lorenzo Pieralisi wrote: > > > On Wed, Sep 02, 2020 at 04:43:42PM +0200, Pali Rohár wrote: > > > > This patch series fixes regression introduced in commit 366697018c9a > > > > ("PCI: aardvark: Add PHY support") which caused aardvark driver > > > > initialization failure on EspressoBin board with factory version of > > > > Arm Trusted Firmware provided by Marvell. > > > > > > > > Second patch depends on the first patch, so please add appropriate > > > > Fixes/Cc:stable@ tags to have both patches correctly backported to > > > > stable kernels. > > > > > > > > I have tested both patches with Marvell ATF firmware ebin-17.10-uart.zip > > > > and with upstream ATF+uboot and aardvark was initialized successfully. > > > > Without this patch series on ebin-17.10-uart.zip aardvark initialization > > > > failed. > > > > > > > > Pali Rohár (2): > > > > phy: marvell: comphy: Convert internal SMCC firmware return codes to > > > > errno > > > > PCI: aardvark: Fix initialization with old Marvell's Arm Trusted > > > > Firmware > > > > > > > > drivers/pci/controller/pci-aardvark.c | 4 +++- > > > > drivers/phy/marvell/phy-mvebu-a3700-comphy.c | 14 +++++++++++--- > > > > drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 14 +++++++++++--- > > > > 3 files changed, 25 insertions(+), 7 deletions(-) > > > > > > Applied to pci/aardvark (both patches), thanks. > > > > Ok! For second patch would be needed to put CC:stable line with > > specifying prerequisite of first patch as written in document: > > > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > > > If I understood it correctly, second patch needs following line: > > > > Cc: # : comphy: errno return codes > > > > where is commit id of PATCH 1/2. > > > > (correct me if I'm wrong) > > > > Now when first commit has commit id, could you update second commit to > > include this information about prerequisite? > > No I can't because they will be merged at the same time. And it is a problem? Git commit id of first patch would not be changed, so referencing to it is now possible from second commit (unless you do rebasing). > What we can do is mark the second patch for stable This is done by adding "Cc: " line to second patch which I suggested, right? > and during the stable review > ask to pull patch (1). Or better you shall send both patches to stable > kernels when they hit Linus' tree. > > Lorenzo