From: Andreas Kemnade <andreas@kemnade.info>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCHv1] power: supply: document current direction
Date: Fri, 2 Oct 2020 18:23:03 +0200 [thread overview]
Message-ID: <20201002182303.51db1289@aktux> (raw)
In-Reply-To: <20200827140248.37749-1-sebastian.reichel@collabora.com>
On Thu, 27 Aug 2020 16:02:48 +0200
Sebastian Reichel <sebastian.reichel@collabora.com> wrote:
> Currently the sign for CURRENT_NOW and CURRENT_AVG is a bit
> of a mess. There are basically 3 different ways battery fuel
> gauges report the current:
>
> 1. uses negative values for discharging and positive values
> for charging
> 2. uses positive values for discharging and negative values
> for discharging (opposit of 1)
> 3. only uses positive values
>
> As a result userspace currently cannot use the sign at all in
> a generic way. Let's solve the issue by documenting a canonical
> way for reporting the data and ensure new drivers follow this
> way. Then existing drivers can be fixed on a case-by-case basis.
>
> The 'negative value = battery discharging' has been choosen,
> since there are only very few drivers doing it the other way
> around.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
would be nice if this comes in, so that is it clearly specified.
Regards,
Andreas
next prev parent reply other threads:[~2020-10-02 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 14:02 [PATCHv1] power: supply: document current direction Sebastian Reichel
2020-10-02 16:23 ` Andreas Kemnade [this message]
2020-10-03 10:48 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002182303.51db1289@aktux \
--to=andreas@kemnade.info \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox