Re: [PATCH v2] net: hso: do not call unregister if not registered

Greg KH
2021-08-16T07:02:49Z

On Mon, Aug 16, 2021 at 08:52:58AM +0200, Salvatore Bonaccorso wrote:
> Hi Greg, Tuba,
>
> On Sun, Oct 04, 2020 at 09:14:33AM +0200, Greg KH wrote:
> > On Sat, Oct 03, 2020 at 05:00:42PM -0700, David Miller wrote:
> > > From: Greg KH <gregkh@linuxfoundation.org>
> > > Date: Fri, 2 Oct 2020 13:43:23 +0200
> > >
> > > > @@ -2366,7 +2366,8 @@ static void hso_free_net_device(struct hso_device *hso_dev, bool bailout)
> > > >
> > > > remove_net_device(hso_net->parent);
> > > >
> > > > - if (hso_net->net)
> > > > + if (hso_net->net &&
> > > > + hso_net->net->reg_state == NETREG_REGISTERED)
> > > > unregister_netdev(hso_net->net);
> > > >
> > > > /* start freeing */
> > >
> > > I really want to get out of the habit of drivers testing the internal
> > > netdev registration state to make decisions.
> > >
> > > Instead, please track this internally. You know if you registered the
> > > device or not, therefore use that to control whether you try to
> > > unregister it or not.
> >
> > Fair enough. Tuba, do you want to fix this up in this way, or do you
> > recommend that someone else do it?
>
> Do I miss something, or did that possibly fall through the cracks?
>
> I was checking some open issues on a downstream distro side and found
> htat this thread did not got a follow-up.

I did not see a follow-up patch :(