From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A053AC4363C for ; Sun, 4 Oct 2020 16:47:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4414D206B6 for ; Sun, 4 Oct 2020 16:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601830021; bh=sVEX0xi2MOLC/1DXKNiNcCpDgAXQI03GADdRHFc9uZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ObIqlVwZP11gLx4VB8a/OEUyRa4YiUpppSX6LdJL5RTVadeju/Sm5KaYtON8+x4R/ 3GU3zvzGyP+8uhHVvZ95GUQzN/5JKWX4dWC4d7cS/3vlRrzdTyFfzvyOdm5UEAdJBz WA6d7WBpSmss8744oUXLMMitNdZOZZ7QVneyXhgo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726107AbgJDQrA (ORCPT ); Sun, 4 Oct 2020 12:47:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:52938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbgJDQq7 (ORCPT ); Sun, 4 Oct 2020 12:46:59 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2218206B6; Sun, 4 Oct 2020 16:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601830019; bh=sVEX0xi2MOLC/1DXKNiNcCpDgAXQI03GADdRHFc9uZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DKamgwob7/jlJskOlG4YZ5v6qF71gImkGZeH95aFI/LtSjGTsPI0kdInTGrTGULNf EOMLWYHZGoDfq38MqYRzaUVMLd80bhqXRpM3SsqXn/3y8dDxNtQoGo6mS8SOQR6dYS /YSh2OwwVGl6JHtT7TKTe5iDR5+g9V5vCUrVjTRQ= Date: Sun, 4 Oct 2020 18:47:45 +0200 From: Greg KH To: pierre kuo Cc: rafael@kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH 2/2] driver core: platform: provide devm_platform_iounremap_resource Message-ID: <20201004164745.GA196660@kroah.com> References: <20200920113808.22223-1-vichy.kuo@gmail.com> <20200920113808.22223-2-vichy.kuo@gmail.com> <20201002134532.GA3419175@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05, 2020 at 12:21:12AM +0800, pierre kuo wrote: > hi Greg: > > Please resend, I can't take patches off of a random web site. > > Now lore.kernel.org I could take them from :) > > Please refer to the attachments and links on lore.kernel.org. > > https://lore.kernel.org/lkml/20200920113808.22223-1-vichy.kuo@gmail.com > https://lore.kernel.org/lkml/20200920113808.22223-2-vichy.kuo@gmail.com Why are you adding new functions but not actually calling them anywhere? We don't like adding infrastructure that no one uses, that's just wasteful. Please redo the series and include some conversions as well, so that we can see if these new functions are even needed or not. thanks, greg k-h