Re: [PATCH v4 2/3] iommu/tegra-smmu: Rework tegra_smmu_probe_device()

Dmitry Osipenko
2020-10-02T14:50:20Z

02.10.2020 17:22, Dmitry Osipenko пишет:
>> static int tegra_smmu_of_xlate(struct device *dev,
>> struct of_phandle_args *args)
>> {
>> + struct platform_device *iommu_pdev = of_find_device_by_node(args->np);
>> + struct tegra_mc *mc = platform_get_drvdata(iommu_pdev);
>> u32 id = args->args[0];
>>
>> + of_node_put(args->np);
>> +
>> + if (!mc || !mc->smmu)
>> + return -EPROBE_DEFER;
> platform_get_drvdata(NULL) will crash.
>

Actually, platform_get_drvdata(NULL) can't happen. I overlooked this.