[PATCH 2/2] media: i2c: imx258: validate rotation only if it is provided

Krzysztof Kozlowski
2020-10-05T15:16:45Z

The sensor supports rotation by 180 degrees however the value of
"rotation" property should be validated only if it exists. If
"rotation" is missing, do not fail the probe:

imx258: probe of 3-001a failed with error -22

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/media/i2c/imx258.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c
index aedf8e7c6165..c52932e5b881 100644
--- a/drivers/media/i2c/imx258.c
+++ b/drivers/media/i2c/imx258.c
@@ -1284,7 +1284,7 @@ static int imx258_probe(struct i2c_client *client)
* supports a single pixel order right now.
*/
ret = device_property_read_u32(&client->dev, "rotation", &val);
- if (ret || val != 180)
+ if (!ret && val != 180)
return -EINVAL;

/* Initialize subdev */
--
2.17.1