From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BE42C41604 for ; Tue, 6 Oct 2020 15:52:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4C53206D4 for ; Tue, 6 Oct 2020 15:52:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726123AbgJFPwX (ORCPT ); Tue, 6 Oct 2020 11:52:23 -0400 Received: from verein.lst.de ([213.95.11.211]:34576 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725769AbgJFPwX (ORCPT ); Tue, 6 Oct 2020 11:52:23 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 3FBDC67373; Tue, 6 Oct 2020 17:52:21 +0200 (CEST) Date: Tue, 6 Oct 2020 17:52:20 +0200 From: Christoph Hellwig To: WeiXiong Liao , Kees Cook Cc: linux-kernel@vger.kernel.org Subject: use case for register_pstore_blk? Message-ID: <20201006155220.GA11668@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi WeiXiong, hi Kees, what is the use case for the code added in commit 17639f67c1d6 ("pstore/blk: Introduce backend for block devices"). This still doesn't have a user, and the API looks really odd to me. By our normal kernel rules we should not add new exports without users and this should probably be reverted for the 5.9 release.