From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
virtio-fs-list <virtio-fs@redhat.com>,
pbonzini@redhat.com
Subject: Re: [PATCH v4] kvm,x86: Exit to user space in case page fault error
Date: Tue, 6 Oct 2020 09:12:00 -0700 [thread overview]
Message-ID: <20201006161200.GB17610@linux.intel.com> (raw)
In-Reply-To: <871rib8ji1.fsf@vitty.brq.redhat.com>
On Tue, Oct 06, 2020 at 05:24:54PM +0200, Vitaly Kuznetsov wrote:
> Vivek Goyal <vgoyal@redhat.com> writes:
> > So you will have to report token (along with -EFAULT) to user space. So this
> > is basically the 3rd proposal which is extension of kvm API and will
> > report say HVA/GFN also to user space along with -EFAULT.
>
> Right, I meant to say that guest kernel has full register state of the
> userspace process which caused APF to get queued and instead of trying
> to extract it in KVM and pass to userspace in case of a (later) failure
> we limit KVM api change to contain token or GFN only and somehow keep
> the rest in the guest. This should help with TDX/SEV-ES.
Whatever gets reported to userspace should be identical with and without
async page faults, i.e. it definitely shouldn't have token information.
Note, TDX doesn't allow injection exceptions, so reflecting a #PF back
into the guest is not an option. Nor do I think that's "correct"
behavior (see everyone's objections to using #PF for APF fixed). I.e. the
event should probably be an IRQ.
next prev parent reply other threads:[~2020-10-06 16:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 21:13 [PATCH v4] kvm,x86: Exit to user space in case page fault error Vivek Goyal
2020-07-27 13:56 ` Vivek Goyal
2020-07-27 16:09 ` Vitaly Kuznetsov
2020-07-27 18:40 ` Vivek Goyal
2020-07-30 5:01 ` Pankaj Gupta
2020-08-07 17:51 ` Vivek Goyal
2020-09-29 4:37 ` Sean Christopherson
2020-10-01 21:55 ` Vivek Goyal
2020-10-01 22:33 ` Sean Christopherson
2020-10-02 15:38 ` Vivek Goyal
2020-10-02 18:30 ` Sean Christopherson
2020-10-02 19:27 ` Vivek Goyal
2020-10-02 19:45 ` Sean Christopherson
2020-10-02 20:02 ` Vivek Goyal
2020-10-02 21:13 ` Sean Christopherson
2020-10-05 15:33 ` Vivek Goyal
2020-10-05 16:16 ` Sean Christopherson
2020-10-06 13:46 ` Vivek Goyal
2020-10-06 14:05 ` Vitaly Kuznetsov
2020-10-06 14:15 ` Vivek Goyal
2020-10-06 14:50 ` Vitaly Kuznetsov
2020-10-06 15:08 ` Vivek Goyal
2020-10-06 15:24 ` Vitaly Kuznetsov
2020-10-06 16:12 ` Sean Christopherson [this message]
2020-10-06 16:24 ` Vivek Goyal
2020-10-06 16:39 ` Vitaly Kuznetsov
2020-10-06 17:17 ` Sean Christopherson
2020-10-06 17:21 ` [Virtio-fs] [PATCH v4] kvm, x86: " Dr. David Alan Gilbert
2020-10-06 17:28 ` Vivek Goyal
2020-10-06 17:35 ` [PATCH v4] kvm,x86: " Vivek Goyal
2020-10-07 0:04 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006161200.GB17610@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).