From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E7E9C4363D for ; Tue, 6 Oct 2020 20:51:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA3002087E for ; Tue, 6 Oct 2020 20:51:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727343AbgJFUvL (ORCPT ); Tue, 6 Oct 2020 16:51:11 -0400 Received: from mga18.intel.com ([134.134.136.126]:19137 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727293AbgJFUvL (ORCPT ); Tue, 6 Oct 2020 16:51:11 -0400 IronPort-SDR: ZhAjQPtXEp7AhraDP0n8Wk0e+9ZiIy7tjkVsW4NmaUCZqezHWC5kw5xXn5eyqKbCBp27yZ6up1 iHlVSxhwZY7w== X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="152454171" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="152454171" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 13:51:08 -0700 IronPort-SDR: 6MRuPVv54ufhdqMKoRfgdP755q19MLAqZ7dy+90lhG8ZFdp0YZpjBX2Y3q62KmXwHWiwM959PQ uoWjHZKWSioA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="297299459" Received: from viggo.jf.intel.com (HELO localhost.localdomain) ([10.54.77.144]) by fmsmga008.fm.intel.com with ESMTP; 06 Oct 2020 13:51:07 -0700 Subject: [RFC][PATCH 00/12] mm: tweak page cache migration To: linux-kernel@vger.kernel.org Cc: Dave Hansen , npiggin@gmail.com, akpm@linux-foundation.org, willy@infradead.org, yang.shi@linux.alibaba.com, linux-mm@kvack.org From: Dave Hansen Date: Tue, 06 Oct 2020 13:51:03 -0700 Message-Id: <20201006205103.268F74A9@viggo.jf.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org First of all, I think this little slice of code is a bit under-documented. Perhaps this will help clarify things. I'm pretty confident the page_count() check in the first patch is right, which is why I removed it outright. The xas_load() check is a bit murkier, so I just left a warning in for it. Cc: Nicholas Piggin Cc: Andrew Morton Cc: Matthew Wilcox (Oracle) Cc: Yang Shi Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org