Re: [PATCH 4/8] x86/mce: Add _ASM_EXTABLE_CPY for copy user access

Borislav Petkov
2020-09-16T09:59:51Z

On Tue, Sep 08, 2020 at 10:55:15AM -0700, Tony Luck wrote:
> diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h
> index cf503824529c..6ea141f91163 100644
> --- a/arch/x86/include/asm/mce.h
> +++ b/arch/x86/include/asm/mce.h
> @@ -137,6 +137,7 @@
> #define MCE_HANDLED_EDAC BIT_ULL(4)
> #define MCE_HANDLED_MCELOG BIT_ULL(5)
> #define MCE_IN_KERNEL_RECOV BIT_ULL(6)
> +#define MCE_IN_KERNEL_COPYIN BIT_ULL(7)

That flag needs a comment explaining what it is. And you can do
MCE_IN_KERNEL_RECOV, while you're at it, there's a nice comment above
its use in do_machine_check which you could use.

Thx.

--
Regards/Gruss,
Boris.