Re: [PATCH 1/8] x86/mce: Stop mce_reign() from re-computing severity for every CPU

Borislav Petkov
2020-09-14T17:22:24Z

On Tue, Sep 08, 2020 at 10:55:12AM -0700, Tony Luck wrote:
> Back in:
>
> commit 20d51a426fe9 ("x86/mce: Reuse one of the u16 padding fields in 'struct mce'")
>
> a field was added to "struct mce" to save the computed error severity.
>
> Make use of this in mce_reign() to avoid re-computing the severity
> for every CPU.

Yah, could go as a standalone optimization...

> In the case where we panic, we do still need one call to mce_severity to
> provide the correct message giving the reason for the panic.

... but pls do not use the "we" formulation as this ambiguous. I'll fix
that up now.

--
Regards/Gruss,
Boris.