From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AF2EC4363D for ; Wed, 7 Oct 2020 13:01:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4958E20659 for ; Wed, 7 Oct 2020 13:01:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728407AbgJGNBn (ORCPT ); Wed, 7 Oct 2020 09:01:43 -0400 Received: from mga02.intel.com ([134.134.136.20]:58172 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728390AbgJGNBn (ORCPT ); Wed, 7 Oct 2020 09:01:43 -0400 IronPort-SDR: ykzXiWQZkktRn7tS09wRlemDnS4bhRuogj290Zy0Js1SPZ5dpwyM7Qeq/041+d9hK0Om8tysua HLGPjF+zz/tA== X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="151860409" X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="151860409" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 06:01:41 -0700 IronPort-SDR: Bt/ncahIGGI1x+byZ3tWuAUkQFB8AfPPmWAoZqQtYaFLENPzoLzBz4QoWT6dyvYMar3RUZmAs7 7m9t3QG31DHw== X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="328045288" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 06:01:38 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kQ95d-0010Nw-8C; Wed, 07 Oct 2020 16:02:41 +0300 Date: Wed, 7 Oct 2020 16:02:41 +0300 From: Andy Shevchenko To: Paul Bolle Cc: Richard Weinberger , Geert Uytterhoeven , Richard Weinberger , Anton Ivanov , Linux Kernel Mailing List , Bartosz Golaszewski , Linus Walleij , Nick Hu , Greentime Hu , Vincent Chen Subject: Re: Build regressions/improvements in v5.9-rc8 Message-ID: <20201007130241.GA4077@smile.fi.intel.com> References: <20201005093024.16032-1-geert@linux-m68k.org> <20201005125840.GP3956970@smile.fi.intel.com> <5f5c303d30eaa32c21131502cc6f28db9d655329.camel@tiscali.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f5c303d30eaa32c21131502cc6f28db9d655329.camel@tiscali.nl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2020 at 02:45:30PM +0200, Paul Bolle wrote: > Richard Weinberger schreef op wo 07-10-2020 om 14:08 [+0200]: > > UML has no ia32 emulation and therefore no in_ia32_syscall(). > > Maybe you can check for CONFIG_IA32_EMULATION too? > > The pending fix is: > #if defined(CONFIG_X86_64) && !defined(CONFIG_UML) > > Since this check guards in_ia32_syscall() just checking CONFIG_IA32_EMULATION > should do too. > > (Way outside my limited expertise, but anyway: is does look odd to see a call > to in_ia32_syscall() in drivers/. All other calls are in arch/x86/. Isn't this > a bit too x86 specific for an arch independent driver?) According to Arnd who suggested that fix the problem is basically appears on x86. He also mentioned the new approach that Christoph Hellwig is working on. But we decided to go the ifdeffery for better backporting. -- With Best Regards, Andy Shevchenko