* [PATCH] mm/hugetlb.c: just use put_page_testzero() instead of page_count()
@ 2020-10-07 17:09 Hui Su
0 siblings, 0 replies; only message in thread
From: Hui Su @ 2020-10-07 17:09 UTC (permalink / raw)
To: mike.kravetz, akpm, linux-mm, linux-kernel
we test the page reference count is zero or not here,
it can be a bug here if page refercence count is not zero.
So we can just use put_page_testzero() instead of
page_count().
Signed-off-by: Hui Su <sh_def@163.com>
---
mm/hugetlb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 67fc6383995b..a274b9ac466f 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -2105,8 +2105,7 @@ static int gather_surplus_pages(struct hstate *h, int delta)
* This page is now managed by the hugetlb allocator and has
* no users -- drop the buddy allocator's reference.
*/
- put_page_testzero(page);
- VM_BUG_ON_PAGE(page_count(page), page);
+ VM_BUG_ON_PAGE(!put_page_testzero(page), page);
enqueue_huge_page(h, page);
}
free:
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-07 17:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-07 17:09 [PATCH] mm/hugetlb.c: just use put_page_testzero() instead of page_count() Hui Su
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox