From: Corey Minyard <minyard@acm.org>
To: "Boehme, Markus" <markubo@amazon.de>
Cc: "Park, Seongjae" <sjpark@amazon.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Nuernberger, Stefan" <snu@amazon.de>,
"openipmi-developer@lists.sourceforge.net"
<openipmi-developer@lists.sourceforge.net>,
"Shah, Amit" <aams@amazon.de>
Subject: Re: [Openipmi-developer] [PATCH 3/3] ipmi: Add timeout waiting for channel information
Date: Wed, 7 Oct 2020 13:42:28 -0500 [thread overview]
Message-ID: <20201007184228.GH3038@minyard.net> (raw)
In-Reply-To: <1599736120.29234.12.camel@amazon.de>
On Thu, Sep 10, 2020 at 11:08:40AM +0000, Boehme, Markus via Openipmi-developer wrote:
> > > - && ipmi_version_minor(id) >= 5)) {
> > > - unsigned int set;
> > > + if (ipmi_version_major(id) == 1 && ipmi_version_minor(id) < 5) {
> > This is incorrect, it will not correctly handle IPMI 0.x BMCs. Yes,
> > they exist.
>
> Interesting! I wasn't aware of those. Searching the web doesn't turn up
> much and the spec doesn't mention them either. Are these pre-release
> implementations of the IPMI 1.0 spec or some kind of "IPMI light"?
There was an 0.9 version of the spec that some machines implemented.
It's not really a "light" version, it's just a really early version. I
don't know how many machine out there still implement it, but I try to
keep them working if I can.
Thanks,
-corey
>
> Markus
next prev parent reply other threads:[~2020-10-07 18:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 16:25 [PATCH 1/3] ipmi: Reset response handler when failing to send the command Markus Boehme
2020-09-07 16:25 ` [PATCH 2/3] ipmi: Add timeout waiting for device GUID Markus Boehme
2020-09-08 0:07 ` Corey Minyard
2020-09-07 16:25 ` [PATCH 3/3] ipmi: Add timeout waiting for channel information Markus Boehme
2020-09-08 0:34 ` Corey Minyard
2020-09-10 11:08 ` Boehme, Markus
2020-10-07 18:42 ` Corey Minyard [this message]
2020-09-08 0:03 ` [PATCH 1/3] ipmi: Reset response handler when failing to send the command Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007184228.GH3038@minyard.net \
--to=minyard@acm.org \
--cc=aams@amazon.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markubo@amazon.de \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=sjpark@amazon.com \
--cc=snu@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox