From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD933C433E7 for ; Thu, 8 Oct 2020 04:53:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51A452173E for ; Thu, 8 Oct 2020 04:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602132833; bh=iqmUTBIDdUuqz2KotJy15SIZ9KrQbHnFX5lfzKeQ8X8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wfmwBBHy7mb6qj1DD0tQcUAi8cl2geR92ci4ujpXfXRdUVcMz/+Q4ddyrZAdCbTfB C3HX2Yl6Q8/azHGvh7arRowNAKGIhxGHknwCXhQefV/Xm1yNwPJhIbPFS4uaLxamK2 dlzdHkAQPchA2ICnJgVsQboWiBHQYnRoVDcFiOWc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728291AbgJHExw (ORCPT ); Thu, 8 Oct 2020 00:53:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:37246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbgJHExw (ORCPT ); Thu, 8 Oct 2020 00:53:52 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E87D2087D; Thu, 8 Oct 2020 04:53:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602132831; bh=iqmUTBIDdUuqz2KotJy15SIZ9KrQbHnFX5lfzKeQ8X8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zktop6C6VdZF/5FN0Eciv9w+xFxDlnIdaILb/s9qtZBfyPx+q5D3Sx9GI8PWc20Ps hQlfzjctLAfe24Xcx/x3YsBmwEXtfmsGTxshPYNsdm44s7rvq2yGH0WFz6SZxj+TlJ op+mPvbi9XEOBV2WGzA2IQYp+l4tIcPrSXFrIOis= Date: Thu, 8 Oct 2020 06:54:35 +0200 From: Greg Kroah-Hartman To: Nathan Chancellor Cc: Mauro Carvalho Chehab , linuxarm@huawei.com, mauro.chehab@huawei.com, John Stultz , Manivannan Sadhasivam , Arnd Bergmann , Derek Kiernan , Dragan Cvetic , linux-kernel@vger.kernel.org, Randy Dunlap Subject: Re: [PATCH] misc: Kconfig: add a new dependency for HISI_HIKEY_USB Message-ID: <20201008045435.GC163423@kroah.com> References: <0e49432d0db9ee8429a9923a1d995935b6b83552.1602047370.git.mchehab+huawei@kernel.org> <20201008021802.GA2858196@ubuntu-m3-large-x86> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201008021802.GA2858196@ubuntu-m3-large-x86> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2020 at 07:18:02PM -0700, Nathan Chancellor wrote: > On Wed, Oct 07, 2020 at 07:09:54AM +0200, Mauro Carvalho Chehab wrote: > > As warned by Randy: > > > > on x86_64: > > CONFIG_USB_ROLE_SWITCH=m > > and HISI_HIKEY_USB=y. > > > > ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_remove': > > hisi_hikey_usb.c:(.text+0x61): undefined reference to `usb_role_switch_unregister' > > ld: hisi_hikey_usb.c:(.text+0xa4): undefined reference to `usb_role_switch_put' > > ld: drivers/misc/hisi_hikey_usb.o: in function `hub_usb_role_switch_set': > > hisi_hikey_usb.c:(.text+0xd3): undefined reference to `usb_role_switch_get_drvdata' > > ld: drivers/misc/hisi_hikey_usb.o: in function `relay_set_role_switch': > > hisi_hikey_usb.c:(.text+0x54d): undefined reference to `usb_role_switch_set_role' > > ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_probe': > > hisi_hikey_usb.c:(.text+0x8a5): undefined reference to `usb_role_switch_get' > > ld: hisi_hikey_usb.c:(.text+0xa08): undefined reference to `usb_role_switch_register' > > ld: hisi_hikey_usb.c:(.text+0xa6e): undefined reference to `usb_role_switch_put' > > > > Make it dependent on CONFIG_USB_ROLE_SWITCH. > > > > Reported-by: Randy Dunlap > > Signed-off-by: Mauro Carvalho Chehab > > --- > > drivers/misc/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > > index e19e1dcceb41..7cee2b72c09e 100644 > > --- a/drivers/misc/Kconfig > > +++ b/drivers/misc/Kconfig > > @@ -459,6 +459,7 @@ config PVPANIC > > config HISI_HIKEY_USB > > tristate "USB GPIO Hub on HiSilicon Hikey 960/970 Platform" > > depends on (OF && GPIOLIB) || COMPILE_TEST > > + depends on CONFIG_USB_ROLE_SWITCH > > Shouldn't this be > > depends on USB_ROLE_SWITCH > > ? Now it will never be selectable. {sigh} Yes, that is correct. Mauro, can you send a fix-up patch for this, as your original is now in my tree. thanks, greg k-h