From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7313C4363C for ; Thu, 8 Oct 2020 06:28:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DA61217BA for ; Thu, 8 Oct 2020 06:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602138507; bh=rGx/tHK9sk8GEZ+IdsjK+5u1fpzknodOEQmNbsMkT/I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=zcLduBJhr9e2i+rDdR4LxTgO2pyQClNNWXilbskMLXvEepJF6agchpMEmfQADSeQb p0PawXHtz7A/LAnEAkm10tWqwR/l/ywATfSTABRXFmJXtFZHs4Cp6NhVZFbSFnyyMz aE2KCto8iUW053SeUnVxtJj3ESmEQYkmDOwTUZ2U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727657AbgJHG20 (ORCPT ); Thu, 8 Oct 2020 02:28:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:43016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726117AbgJHG2Z (ORCPT ); Thu, 8 Oct 2020 02:28:25 -0400 Received: from coco.lan (ip5f5ad5d8.dynamic.kabel-deutschland.de [95.90.213.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1740A20782; Thu, 8 Oct 2020 06:28:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602138505; bh=rGx/tHK9sk8GEZ+IdsjK+5u1fpzknodOEQmNbsMkT/I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Isqt2nMZQ/msZy3rrJO1dkoKGf3EOi1uZBykw+xIFT9/xiWZGo4Uv1jzwO3DeEqdd W+rSahuNBkctSu3w5/PWyplJSBQ5lQ54Twilc7ihWypc4jvVb7aDH+7ga184dF0rjG WVN6PjMNAd27Ju+76hxVCJ4vCXuNC1J8m7N64x8s= Date: Thu, 8 Oct 2020 08:28:18 +0200 From: Mauro Carvalho Chehab To: Greg Kroah-Hartman Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, John Stultz , Manivannan Sadhasivam , Arnd Bergmann , Derek Kiernan , Dragan Cvetic , linux-kernel@vger.kernel.org, Randy Dunlap Subject: Re: [PATCH v2] misc: Kconfig: add a new dependency for HISI_HIKEY_USB Message-ID: <20201008082818.6342737a@coco.lan> In-Reply-To: <20201008061443.GB172088@kroah.com> References: <20201008061443.GB172088@kroah.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, 8 Oct 2020 08:14:43 +0200 Greg Kroah-Hartman escreveu: > On Thu, Oct 08, 2020 at 07:30:27AM +0200, Mauro Carvalho Chehab wrote: > > As warned by Randy: > > > > on x86_64: > > CONFIG_USB_ROLE_SWITCH=m > > and HISI_HIKEY_USB=y. > > > > ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_remove': > > hisi_hikey_usb.c:(.text+0x61): undefined reference to `usb_role_switch_unregister' > > ld: hisi_hikey_usb.c:(.text+0xa4): undefined reference to `usb_role_switch_put' > > ld: drivers/misc/hisi_hikey_usb.o: in function `hub_usb_role_switch_set': > > hisi_hikey_usb.c:(.text+0xd3): undefined reference to `usb_role_switch_get_drvdata' > > ld: drivers/misc/hisi_hikey_usb.o: in function `relay_set_role_switch': > > hisi_hikey_usb.c:(.text+0x54d): undefined reference to `usb_role_switch_set_role' > > ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_probe': > > hisi_hikey_usb.c:(.text+0x8a5): undefined reference to `usb_role_switch_get' > > ld: hisi_hikey_usb.c:(.text+0xa08): undefined reference to `usb_role_switch_register' > > ld: hisi_hikey_usb.c:(.text+0xa6e): undefined reference to `usb_role_switch_put' > > > > Make it dependent on CONFIG_USB_ROLE_SWITCH. > > > > Reported-by: Randy Dunlap > > Signed-off-by: Mauro Carvalho Chehab > > --- > > drivers/misc/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > > index e19e1dcceb41..d5ce8082b0a0 100644 > > --- a/drivers/misc/Kconfig > > +++ b/drivers/misc/Kconfig > > @@ -459,6 +459,7 @@ config PVPANIC > > config HISI_HIKEY_USB > > tristate "USB GPIO Hub on HiSilicon Hikey 960/970 Platform" > > depends on (OF && GPIOLIB) || COMPILE_TEST > > + depends on USB_ROLE_SWITCH > > help > > If you say yes here this adds support for the on-board USB GPIO hub > > found on HiKey 960/970 boards, which is necessary to support > > I can't rebase my tree, so can you send the fix-up patch instead, with > the proper "reported-by:"? Sent. You may need to adjust the Fixes: line there, in order to point to the right changeset on your tree. Thanks, Mauro