Re: [PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land

Coiby Xu
2020-10-10T11:20:49Z

On Sat, Oct 10, 2020 at 05:01:26PM +0900, Benjamin Poirier wrote:
>On 2020-10-08 19:58 +0800, Coiby Xu wrote:
>> The debugging code in the following ifdef land
>> - QL_ALL_DUMP
>> - QL_REG_DUMP
>> - QL_DEV_DUMP
>> - QL_CB_DUMP
>> - QL_IB_DUMP
>> - QL_OB_DUMP
>>
>> becomes unnecessary because,
>> - Device status and general registers can be obtained by ethtool.
>> - Coredump can be done via devlink health reporter.
>> - Structure related to the hardware (struct ql_adapter) can be obtained
>> by crash or drgn.
>>
>> Suggested-by: Benjamin Poirier <benjamin.poirier@gmail.com>
>> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
>> ---
>> drivers/staging/qlge/qlge.h | 82 ----
>> drivers/staging/qlge/qlge_dbg.c | 688 ----------------------------
>> drivers/staging/qlge/qlge_ethtool.c | 2 -
>> drivers/staging/qlge/qlge_main.c | 7 +-
>
>Please also update drivers/staging/qlge/TODO accordingly. There is still
>a lot of debugging code IMO (the netif_printk statements - kernel
>tracing can be used instead of those) but this patch is a substantial
>improvement.

Thank you for the reminding! To move qlge out of staging tree would be
interesting exercise for me:)

--
Best regards,
Coiby