Re: [PATCH 05/13] selftests: pidfd: use ksft_test_result_skip() when skipping test

Christian Brauner
2020-10-09T12:03:43Z

On Thu, Oct 08, 2020 at 03:26:25PM +0300, Tommi Rantala wrote:
> There's planned tests != run tests in pidfd_test when some test is
> skipped:
>
> $ ./pidfd_test
> TAP version 13
> 1..8
> [...]
> # pidfd_send_signal signal recycled pid test: Skipping test
> # Planned tests != run tests (8 != 7)
> # Totals: pass:7 fail:0 xfail:0 xpass:0 skip:0 error:0
>
> Fix by using ksft_test_result_skip():
>
> $ ./pidfd_test
> TAP version 13
> 1..8
> [...]
> ok 8 # SKIP pidfd_send_signal signal recycled pid test: Unsharing pid namespace not permitted
> # Totals: pass:7 fail:0 xfail:0 xpass:0 skip:1 error:0
>
> Signed-off-by: Tommi Rantala <tommi.t.rantala@nokia.com>
> ---

Thanks, I never got around to fixing this myself.
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>