From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CE87C43457 for ; Thu, 8 Oct 2020 16:41:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDB1821D7D for ; Thu, 8 Oct 2020 16:40:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="cKsHpOyt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731310AbgJHQk7 (ORCPT ); Thu, 8 Oct 2020 12:40:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731063AbgJHQky (ORCPT ); Thu, 8 Oct 2020 12:40:54 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96B59C061755 for ; Thu, 8 Oct 2020 09:40:54 -0700 (PDT) Received: from zn.tnic (p200300ec2f0a90005296687463b5d995.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:9000:5296:6874:63b5:d995]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4C1241EC026E; Thu, 8 Oct 2020 18:40:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1602175253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=WAW/8JS2d7+2AncJGT2XwPHgun5v4p5JAJ8o7kGFtnc=; b=cKsHpOyt8bOEP/H93R9p4sOrBoO6XhPGzA/+VVuFpCEHED+7OkiPgn1ioIrByKT37Qo90z fSDlZ078dCt1fExk3Eu15oTwAZ2kniS3mDzrHgZk4Koq6+RwrYB4ubiar/5C9ksBHCClJU gCclpMfWcfK0xWEvvzz2CVF21yv3qk8= Date: Thu, 8 Oct 2020 18:40:44 +0200 From: Borislav Petkov To: Enric Balletbo i Serra Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Collabora Kernel ML , Thomas Gleixner , Ingo Molnar , Diego Elio =?utf-8?Q?Petten=C3=B2?= , "H. Peter Anvin" , "Martin K. Petersen" , Nathan Chancellor , Randy Dunlap , Willy Tarreau Subject: Re: [PATCH] x86/x86_64_defconfig: Enable the serial console Message-ID: <20201008164044.GE5505@zn.tnic> References: <20201008162206.862203-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201008162206.862203-1-enric.balletbo@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2020 at 06:22:06PM +0200, Enric Balletbo i Serra wrote: > As part of KernelCI, we added a bunch of different x86 based Chromebooks > to do test booting and runtime testing. It will be useful have serial > support for these platforms in the default defconfig, as this, is the > defconfig used by default for the different maintainer's tree. > > SERIAL_8250_DW is the actual support for the console, but to have > support we need to enable X86_AMD_PLATFORM_DEVICE for specific AMD > boards and MFD_INTEL for specific Intel boards. > > While here, also enable USB_RTL8152 config which enables a common > USB-Ethernet adapter used very commonly in the KernelCI labs. To me defconfig sounds like the config which contains items which are needed on the majority of x86 hardware out there. Are those which you enable that common and if not, why can't your build supply a custom .config instead? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette