From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 381AFC433E7 for ; Fri, 9 Oct 2020 05:46:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A741F22240 for ; Fri, 9 Oct 2020 05:46:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="FJ/tXpD0"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="lPzBjITb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731271AbgJIFqz (ORCPT ); Fri, 9 Oct 2020 01:46:55 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:45327 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725917AbgJIFqz (ORCPT ); Fri, 9 Oct 2020 01:46:55 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B08505C00FB; Fri, 9 Oct 2020 01:46:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 09 Oct 2020 01:46:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=lr6M8yNWNeNhl0M7Uihv92Zrbfw BaHLmXICbGyQw3sw=; b=FJ/tXpD0Y7sB0j+cc5vQf+iH2TZGeRZXYgUxYBpWp22 M/rU3q47XK6L2i3skTzn5H7TMHBYmyJ1hCLO6s6/vcaHctVvV5hm+R1CkKVVCj// F++o4MQaaNY4+okaADmWuiXixSf4Aw7+cRIS6k1dNrfLUfm0SApp2MnBlxf5T1P3 bOOtfIct1mPO8ejAgeFGC+fW2H7LF9eNUZHWg6iLKXVStiHlzP3DpNjHtPopYa+X KBbqQUpV31r8QtGbkz2345GOsUWTZ0dJiGGxiZU+sWxLXfru2xV+lWDDuTdhyANW j7wGnIFAcWIgVrHpPwRMOgNpyMC+LIzwoGyF0nY6Gbg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=lr6M8y NWNeNhl0M7Uihv92ZrbfwBaHLmXICbGyQw3sw=; b=lPzBjITbjluDqdA+x3a6p1 fXUE5PHtDHEybWDeXsIEc4LTD1nRvMtrs2qxOJUuU39ay5Kgp+e2XzjmpPBaHPRr 6xozogYcCQr/UQQa6BpPAYlTIaas6JfwDGZM4ZNStAbfoGnlhb+OHjwMDeWZYWhS dDdUqu3ZcH7s6Vvrq3n5Eo5z+Xl9dc2nP4kTsCcL0E6en/iLdB9r8Gv2sBZ/jfkF 8JVvV6BiTZsbeTYI+JdZJQHVHmU1qUQeKF+SNaldHros5EM7AFlp3fmjY5bQKNXF 6AqMN0Ss43l7BwnEJik6pPv81lZd1kwxmKoYlXVZciY/6CGVODi7YPOAyfGzvDLw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrhedtgdellecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghgucfm jfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuheejgf ffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecukfhppeekfedr keeirdejgedrieegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepghhrvghgsehkrhhorghhrdgtohhm X-ME-Proxy: Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) by mail.messagingengine.com (Postfix) with ESMTPA id 2AD563064610; Fri, 9 Oct 2020 01:46:52 -0400 (EDT) Date: Fri, 9 Oct 2020 07:46:50 +0200 From: Greg KH To: Joel Stanley Cc: Ryan Chen , Andrew Jeffery , Linux ARM , linux-aspeed , Linux Kernel Mailing List , linux-usb@vger.kernel.org, BMC-SW , Alan Stern Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig Message-ID: <20201009054650.GA117723@kroah.com> References: <20200930040823.26065-4-ryan_chen@aspeedtech.com> <20201009024937.11246-1-ryan_chen@aspeedtech.com> <20201009024937.11246-2-ryan_chen@aspeedtech.com> <20201009044526.GB111063@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 09, 2020 at 04:55:19AM +0000, Joel Stanley wrote: > On Fri, 9 Oct 2020 at 04:45, Greg KH wrote: > > > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > > v2: > > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > > v1: > > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > > > Signed-off-by: Ryan Chen > > > > Why do you need this in a defconfig? > > I would prefer configurations that are being used to be present in the > defconfig so we can test it. I think this is a sensible change. Then it needs to be described in the changelog, otherwise we have no idea why this is happening :) thanks, greg k-h