From: Jiri Olsa <jolsa@redhat.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf c2c: Update usage for showing memory events
Date: Mon, 12 Oct 2020 11:13:48 +0200 [thread overview]
Message-ID: <20201012091348.GC1099489@krava> (raw)
In-Reply-To: <20201011121022.22409-1-leo.yan@linaro.org>
On Sun, Oct 11, 2020 at 08:10:22PM +0800, Leo Yan wrote:
> Since commit b027cc6fdf1b ("perf c2c: Fix 'perf c2c record -e list' to
> show the default events used"), "perf c2c" tool can show the memory
> events properly, it's no reason to still suggest user to use the
> command "perf mem record -e list" for showing events.
>
> This patch updates the usage for showing memory events with command
> "perf c2c record -e list".
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
> ---
> tools/perf/builtin-c2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 5938b100eaf4..57bb6cce43e3 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -2916,7 +2916,7 @@ static int perf_c2c__record(int argc, const char **argv)
> bool event_set = false;
> struct option options[] = {
> OPT_CALLBACK('e', "event", &event_set, "event",
> - "event selector. Use 'perf mem record -e list' to list available events",
> + "event selector. Use 'perf c2c record -e list' to list available events",
> parse_record_events),
> OPT_BOOLEAN('u', "all-user", &all_user, "collect only user level data"),
> OPT_BOOLEAN('k', "all-kernel", &all_kernel, "collect only kernel level data"),
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-10-12 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 12:10 [PATCH] perf c2c: Update usage for showing memory events Leo Yan
2020-10-12 9:13 ` Jiri Olsa [this message]
2020-10-12 15:25 ` Ian Rogers
2020-10-13 16:16 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012091348.GC1099489@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox