From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E89C433E7 for ; Mon, 12 Oct 2020 14:08:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C76672076E for ; Mon, 12 Oct 2020 14:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602511737; bh=yloeu97dfZZuSm52IkAE8ooQqLlVCu0spAt8RkZ6HBU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Jpk/JrC2eJF2WyS32TLkG2CYSRdjLRapmC87tFs/7BcA853Et0+5qB+0eJagNR91o jNA0wVae2rKlEMn1PENYqVzQIEUSl/2oeYrs8qbUeFwK7EsbLYo4sY4RKLuHnGc/nz ivkoZw0nUX7CBke40hf53XNhhHvKie+Y+Y6I65TE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731921AbgJLOI4 (ORCPT ); Mon, 12 Oct 2020 10:08:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:35530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726897AbgJLNdX (ORCPT ); Mon, 12 Oct 2020 09:33:23 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 80CEC204EA; Mon, 12 Oct 2020 13:33:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602509603; bh=yloeu97dfZZuSm52IkAE8ooQqLlVCu0spAt8RkZ6HBU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tlW58lSZ3siH3qpyF/MoYZgh0kyfndOgym+5Q5LyCaVLmxjCpyPdxHB7AzzYpQCiD hkHZ3ETrpjJv3b7+i5d1+48oVAQ358fVw8TUQHWI9cGnwbVlR0Umor6KobdpLxLyaT 9/z+0M2/gDbQjjMLXw1D2/Kl18Kx8z9h+yidhSpw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aaron Ma , Andy Shevchenko Subject: [PATCH 4.4 24/39] platform/x86: thinkpad_acpi: re-initialize ACPI buffer size when reuse Date: Mon, 12 Oct 2020 15:26:54 +0200 Message-Id: <20201012132629.290609899@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201012132628.130632267@linuxfoundation.org> References: <20201012132628.130632267@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aaron Ma commit 720ef73d1a239e33c3ad8fac356b9b1348e68aaf upstream. Evaluating ACPI _BCL could fail, then ACPI buffer size will be set to 0. When reuse this ACPI buffer, AE_BUFFER_OVERFLOW will be triggered. Re-initialize buffer size will make ACPI evaluate successfully. Fixes: 46445b6b896fd ("thinkpad-acpi: fix handle locate for video and query of _BCL") Signed-off-by: Aaron Ma Signed-off-by: Andy Shevchenko Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/thinkpad_acpi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -6362,8 +6362,10 @@ static int __init tpacpi_query_bcl_level list_for_each_entry(child, &device->children, node) { acpi_status status = acpi_evaluate_object(child->handle, "_BCL", NULL, &buffer); - if (ACPI_FAILURE(status)) + if (ACPI_FAILURE(status)) { + buffer.length = ACPI_ALLOCATE_BUFFER; continue; + } obj = (union acpi_object *)buffer.pointer; if (!obj || (obj->type != ACPI_TYPE_PACKAGE)) {