Re: [PATCH v2 2/2] [RFC] CPUFreq: Add support for cpu-perf-dependencies

Ionela Voinescu
2020-10-08T17:08:20Z

Hi Rafael,

On Thursday 08 Oct 2020 at 17:57:23 (+0200), Rafael J. Wysocki wrote:
> On Thu, Oct 8, 2020 at 5:03 PM Ionela Voinescu <ionela.voinescu@arm.com> wrote:
> >
> > Hi Viresh,
> >
> > On Thursday 08 Oct 2020 at 16:32:41 (+0530), Viresh Kumar wrote:
> > > On 07-10-20, 13:58, Nicola Mazzucato wrote:
> > > > Hi Viresh,
> > > >
> > > > performance controls is what is exposed by the firmware through a protocol that
> > > > is not capable of describing hardware (say SCMI). For example, the firmware can
> > > > tell that the platform has N controls, but it can't say to which hardware they
> > > > are "wired" to. This is done in dt, where, for example, we map these controls
> > > > to cpus, gpus, etc.
> > > >
> > > > Let's focus on cpus.
> > > >
> > > > Normally we would have N of performance controls (what comes from f/w)
> > > > that that correspond to hardware clock/dvfs domains.
> > > >
> > > > However, some firmware implementations might benefit from having finer
> > > > grained information about the performance requirements (e.g.
> > > > per-CPU) and therefore choose to present M performance controls to the
> > > > OS. DT would be adjusted accordingly to "wire" these controls to cpus
> > > > or set of cpus.
> > > > In this scenario, the f/w will make aggregation decisions based on the
> > > > requests it receives on these M controls.
> > > >
> > > > Here we would have M cpufreq policies which do not necessarily reflect the
> > > > underlying clock domains, thus some s/w components will underperform
> > > > (EAS and thermal, for example).
> > > >
> > > > A real example would be a platform in which the firmware describes the system
> > > > having M per-cpu control, and the cpufreq subsystem will have M policies while
> > > > in fact these cpus are "performance-dependent" each other (e.g. are in the same
> > > > clock domain).
> > >
> > > If the CPUs are in the same clock domain, they must be part of the
> > > same cpufreq policy.
> >
> > But cpufreq does not currently support HW_ALL (I'm using the ACPI
> > coordination type to describe the generic scenario of using hardware
> > aggregation and coordination when establishing the clock rate of CPUs).
> >
> > Adding support for HW_ALL* will involve either bypassing some
> > assumptions around cpufreq policies or making core cpufreq changes.
> >
> > In the way I see it, support for HW_ALL involves either:
> >
> > - (a) Creating per-cpu policies in order to allow each of the CPUs to
> > send their own frequency request to the hardware which will do
> > aggregation and clock rate decision at the level of the clock
> > domain.
>
> This has been done for years on many platforms.

Exactly!

>
> > The PSD domains (ACPI) and the new DT binding will tell
> > which CPUs are actually in the same clock domain for whomever is
> > interested, despite those CPUs not being in the same policy.
>
> And this information hasn't been used so far in those cases.
>
> > This requires the extra mask that Nicola introduced.
>
> What would you use it for, specifically?

This would be useful for:

- Energy Aware Scheduling: for this you need to know how other CPUs in
a clock domain would be impacted by a task placement. For example,
if the utilization of a CPU would increase as a result of a certain
task placement choice and as a result (for schedutil) its clock rate
need would increase as well, this increase in the clock rate, and
therefore energy, of the entire domain is considered before making
that task placement choice.

- Thermal: the usefulness is dependent on the distribution of thermal
zones and their attached cooling devices. But with knowledge about
what CPUs use the same clock, the thermal governors could cap all
dependent CPUs in one go, while for some governor (IPA) knowing about
dependent CPUs help with more accurate power allocation, similar to
EAS.

- Frequency invariance: ideally one would have counters for this,
but when lacking counters, even knowing that some CPUs have the same
frequency and after using some software aggregation (likely maximum)
to establish what that frequency might be, I believe it would still
be more useful than no frequency invariance at all.

Even if in these cases you don't have accurate information about the
frequency that hardware will grant, knowing that some CPUs will change
frequency together is useful. Given that some of the above users (EAS,
IPA) are proactive and are trying to predict the future state of a
system, they did not have completely accurate information to begin with.
But not taking into account CPUs sharing a clock will result in too
much inaccuracy (that even control loops and can't compensate for).
This together with the assumption* that predicted frequencies won't be
very far off from granted frequencies will result in maintaining these
features in a more useful state.

*my assumption, until proven otherwise :)

>
> > - (b) Making deep changes to cpufreq (core/governors/drivers) to allow:
>
> Not an option really.

Agreed!

Thanks,
Ionela.