Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

Borislav Petkov
2020-10-11T15:58:58Z

On Sun, Oct 11, 2020 at 05:40:27PM +0200, Enric Balletbo i Serra wrote:
> How do you quantify those things are NOT common enough? Do you have a number?

I don't want to change the defconfig - you do. So quantifying is in your
court - not mine.

> I don't have a number, the only I can tell is that both symbols enable support
> for I2C, SPI an HS-UART. The AMD one, is found on AMD Carrizo and later
> chipsets, the Intel one, is found on Intel Skylake and later. I.e Lots of
> laptops need these to have support for the touchpad.

That sounds like a step in the right direction.

> KernelCI is focused on upstream kernel development. KernelCI builds lots of
> different versions of the kernel, including stable kernels, and maintainers
> trees. It does tests on real hardware, so having a config supporting as much as
> possible the x86 hardware that we have in the KernelCI labs will help us to
> increase the test coverage and catch more issues.

So those issues - where do you guys report them? Because I've never seen
one reported by kernelCI, AFAIR. I see 0day bot and syzbot doing such
reports on a regular basis but none from kernelCI AFAIK. Do you send
your bug reports to lkml and Cc the relevant parties?

> Yes, it can. As I said, is a matter of maintenance, if we do this we
> will have a different workflow for x86 hardware.

Lemme get this straight - your workflow would do:

$ make defconfig

and now here you'd have to add a single command:

$ .scripts/kconfig/merge_config.sh -m .config .kernelci.config.snippet

in order to get the symbols you want, enabled.

I've shown this one because this is how those other configs like
kvm_guest.config and xen.config work - they're config snippets and they
get merged with a preexisting config, see scripts/kconfig/Makefile.

Now, is that additional single command worth "hours of maintenance time"
or is it something you can do easily? As in:

if (x86)
<command>

?

Thx.

--
Regards/Gruss,
Boris.