From: Borislav Petkov <bp@alien8.de>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
X86 ML <x86@kernel.org>, Andy Whitcroft <apw@canonical.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH -v4] checkpatch: Check for .byte-spelled insn opcodes documentation on x86
Date: Mon, 12 Oct 2020 19:15:44 +0200 [thread overview]
Message-ID: <20201012171544.GH22829@zn.tnic> (raw)
In-Reply-To: <b74a95944a4bc6be1ea4ae8cf065c23e03511ba5.camel@perches.com>
On Mon, Oct 12, 2020 at 10:09:44AM -0700, Joe Perches wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Instruction opcode bytes spelled using the gas directive .byte should
> carry a comment above them stating which binutils version has added
> support for the instruction mnemonic so that they can be replaced with
> the mnemonic when that binutils version is equal or less than the
> minimum-supported version by the kernel.
>
> Add a check for that.
>
> Requested-by: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>
> v4: trivial neatening of $Hex_byte and adding a mechanism to
> only emit the message once per patched file (Joe)
>
> scripts/checkpatch.pl | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
./scripts/checkpatch.pl /tmp/test
Global symbol "$rawline" requires explicit package name (did you forget to declare "my $rawline"?) at ./scripts/checkpatch.pl line 6943.
Global symbol "$herecurr" requires explicit package name (did you forget to declare "my $herecurr"?) at ./scripts/checkpatch.pl line 6948.
Execution of ./scripts/checkpatch.pl aborted due to compilation errors.
No workie.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-10-12 17:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 16:14 [PATCH] checkpatch: Check for .byte-spelled insn opcodes documentation on x86 Borislav Petkov
2020-10-09 18:01 ` Joe Perches
2020-10-10 10:54 ` Borislav Petkov
2020-10-10 10:55 ` [PATCH -v2] " Borislav Petkov
2020-10-10 15:27 ` [PATCH] " Joe Perches
2020-10-10 16:11 ` Borislav Petkov
2020-10-10 16:47 ` Joe Perches
2020-10-12 14:21 ` Borislav Petkov
2020-10-12 14:23 ` [PATCH -v3] " Borislav Petkov
2020-10-12 15:04 ` Joe Perches
2020-10-12 15:02 ` [PATCH] " Joe Perches
2020-10-12 17:09 ` [PATCH -v4] " Joe Perches
2020-10-12 17:15 ` Borislav Petkov [this message]
2020-10-12 17:17 ` Joe Perches
2020-10-12 17:31 ` Borislav Petkov
2020-10-12 17:40 ` Joe Perches
2020-10-12 17:55 ` Borislav Petkov
2020-10-12 18:03 ` Joe Perches
2020-10-10 15:38 ` [PATCH] " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012171544.GH22829@zn.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox