From: Juri Lelli <juri.lelli@redhat.com>
To: Patrick Bellasi <patrick.bellasi@matbug.net>
Cc: peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, bristot@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
chris.redpath@arm.com, rostedt@goodmis.org, bsegall@google.com,
mgorman@suse.de, valentin.schneider@arm.com
Subject: Re: [PATCH v2] sched/features: Fix !CONFIG_JUMP_LABEL case
Date: Tue, 13 Oct 2020 12:48:11 +0200 [thread overview]
Message-ID: <20201013104811.GE89256@localhost.localdomain> (raw)
In-Reply-To: <878scail9o.derkling@matbug.net>
On 13/10/20 10:26, Patrick Bellasi wrote:
>
> On Tue, Oct 13, 2020 at 07:31:14 +0200, Juri Lelli <juri.lelli@redhat.com> wrote...
>
> > Commit 765cc3a4b224e ("sched/core: Optimize sched_feat() for
> > !CONFIG_SCHED_DEBUG builds") made sched features static for
> > !CONFIG_SCHED_DEBUG configurations, but overlooked the CONFIG_
> > SCHED_DEBUG enabled and !CONFIG_JUMP_LABEL cases. For the latter echoing
> > changes to /sys/kernel/debug/sched_features has the nasty effect of
> > effectively changing what sched_features reports, but without actually
> > changing the scheduler behaviour (since different translation units get
> > different sysctl_sched_features).
>
> Hops, yes, I think I missed to properly check that config :/
> Good spot!
>
> > Fix CONFIG_SCHED_DEBUG and !CONFIG_JUMP_LABEL configurations by properly
> > restructuring ifdefs.
> >
> > Fixes: 765cc3a4b224e ("sched/core: Optimize sched_feat() for !CONFIG_SCHED_DEBUG builds")
> > Co-developed-by: Daniel Bristot de Oliveira <bristot@redhat.com>
> > Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
> > Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
>
> (did you get some wrong formatting for the changelog above?)
Hummm, what you mean?
I intended to follow
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L566
next prev parent reply other threads:[~2020-10-13 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 5:31 [PATCH v2] sched/features: Fix !CONFIG_JUMP_LABEL case Juri Lelli
2020-10-13 8:26 ` Patrick Bellasi
2020-10-13 10:48 ` Juri Lelli [this message]
2020-10-13 10:02 ` [tip: sched/urgent] " tip-bot2 for Juri Lelli
2020-10-14 17:58 ` tip-bot2 for Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013104811.GE89256@localhost.localdomain \
--to=juri.lelli@redhat.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=chris.redpath@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox