From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 994B5C433DF for ; Wed, 14 Oct 2020 08:38:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 431B620BED for ; Wed, 14 Oct 2020 08:38:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729679AbgJNIiB (ORCPT ); Wed, 14 Oct 2020 04:38:01 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:58222 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726269AbgJNIiB (ORCPT ); Wed, 14 Oct 2020 04:38:01 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 75E1B1C0B87; Wed, 14 Oct 2020 10:37:59 +0200 (CEST) Date: Wed, 14 Oct 2020 10:37:58 +0200 From: Pavel Machek To: Udo van den Heuvel Cc: Takashi Iwai , Randy Dunlap , "linux-kernel@vger.kernel.org" , linux-leds@vger.kernel.org, Dan Murphy , moderated for non-subscribers Subject: Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK) Message-ID: <20201014083758.GB31728@amd> References: <1e6b1961-9e9b-5f82-86a1-bf838cb68f55@xs4all.nl> <20201014075853.GB29881@amd> <056a8933-378f-30f2-c7af-5514d93d3c36@xs4all.nl> <20201014081116.GC29881@amd> <2be6e184-97d4-a2b1-a500-6ea3528cff37@xs4all.nl> <20201014082752.GA31728@amd> <9cf705b9-1fca-2445-43de-916b13b9103f@xs4all.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CUfgB8w4ZwR/yMy5" Content-Disposition: inline In-Reply-To: <9cf705b9-1fca-2445-43de-916b13b9103f@xs4all.nl> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --CUfgB8w4ZwR/yMy5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2020-10-14 10:34:21, Udo van den Heuvel wrote: > On 14-10-2020 10:27, Pavel Machek wrote: > >> One should have thought about stuff beforehand. > >=20 > > We did. And decided this is best solution. >=20 > Then the thought process went awry. >=20 > >> The non-selectability is not my fault. > >=20 > > It also does not affect you in any way. >=20 > It does. > /boot fills up even sooner thanks to this unused code. > Compiles last longer because of this unused code. Have you measured how much slower and how much bigger it is? Do you understand that you propose to make source code bigger and slower to compile for everyone else? You are filling my inbox. > > Feel free to go to the mic LED discussion to see why we did it like > > this. Then you can come up with better solution for problem at hand. >=20 > I did not think of forcing code onto somebody. Someone else did. > This is effectively the effect of the LEDs thing. Without understanding what was decided and why, this discussion is not useful. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --CUfgB8w4ZwR/yMy5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl+GuOYACgkQMOfwapXb+vJMOACeINaNJ284URcw5rkEnAaaBLD3 AUkAoK9ipT87VRbgXSFTZYc9dMa1g4go =0WBC -----END PGP SIGNATURE----- --CUfgB8w4ZwR/yMy5--