From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76FE8C43457 for ; Wed, 14 Oct 2020 20:00:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D837206DC for ; Wed, 14 Oct 2020 20:00:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="GgyKcWz5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728825AbgJNUAE (ORCPT ); Wed, 14 Oct 2020 16:00:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbgJNUAD (ORCPT ); Wed, 14 Oct 2020 16:00:03 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84265C061755; Wed, 14 Oct 2020 13:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dBOYMLQQlx6kYOwTChDpfwiT4F6gbGW7SjYy3hlDmqI=; b=GgyKcWz5leHygg4kK7woUaWtj1 fOgwoaMk9of07DvgpbLTw5a9s7c6HlXJXaKsm+VoT+L9yG1ZDum6iwHXCX4dRtM36x1EteAVeJGYS wbTMPw4GfHYc+T8kxVvk5KXO+AN6qLM9Q5gcSkT9k3FiWgMUz7O4usJqTkaTtQ+82R6KKoV/C+NQP Q0IznlIbhkht1EtekWFMVzJbx+q+NtuWoMpwpAXihsvpSRF6BHn3bAQZKZLvH2lfYc/jgY49EChTc N76u96GbNxWc+J6DKthDv3KaUGz4sH3Q7PjhKns2jC3URthZKv2RSm3/5weo+0VWhGElRb1zR1ipf 88j7zmjw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSmw9-0002gi-CM; Wed, 14 Oct 2020 19:59:49 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 0682E980F54; Wed, 14 Oct 2020 21:59:49 +0200 (CEST) Date: Wed, 14 Oct 2020 21:59:48 +0200 From: Peter Zijlstra To: Ian Rogers Cc: Brendan Higgins , Vitor Massaru Iha , KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , Shuah Khan , linux-kernel-mentees@lists.linuxfoundation.org, Ingo Molnar Subject: Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit Message-ID: <20201014195948.GE2974@worktop.programming.kicks-ass.net> References: <20200729201146.537433-1-vitor@massaru.org> <20200729203908.GD2655@hirez.programming.kicks-ass.net> <20200804132517.GK2657@hirez.programming.kicks-ass.net> <20200804142344.GM2674@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2020 at 11:16:10AM -0700, Ian Rogers wrote: > There were some issues in the original patch, they should be easy to > fix. I'm more concerned that Peter's issues are addressed about the > general direction of the patch, verbosity and testing frameworks. I > see Vitor followed up with Peter but I'm not sure that means the > approach has been accepted. I kinda lost track, as long as it doesn't get more verbose I suppose I'm fine.